Skip to content

Remote development environments changes #5359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 20, 2021
Merged

Remote development environments changes #5359

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7be1268
Remote development changes.
lbogdan Jan 12, 2021
4f9750a
Fix type warning.
lbogdan Jan 12, 2021
f855be3
Sleep 15s before starting app to give common and components a chance …
lbogdan Jan 12, 2021
cd41194
Fix / stringify DEV_DOMAIN environment variable.
lbogdan Jan 12, 2021
a839611
Merge remote-tracking branch 'origin/master' into feat/remote-dev
lbogdan Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix / stringify DEV_DOMAIN environment variable.
  • Loading branch information
@lbogdan
lbogdan committed Jan 12, 2021
commit cd411943f4f17172c9b4e87d80ffdd2d9289b472
2 changes: 1 addition & 1 deletion packages/common/src/config/env.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,6 @@ export default Object.keys(process.env)
'process.env.SANDPACK': Boolean(
JSON.parse(process.env.SANDPACK || 'false')
),
'process.env.DEV_DOMAIN': process.env.DEV_DOMAIN || 'codesandbox.test',
'process.env.DEV_DOMAIN': JSON.stringify(process.env.DEV_DOMAIN || 'codesandbox.test'),
}
);