Switch collection hook to use pathlib paths #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I stuffed some fixes for CI & docs into this pull request; I was too lazy to create separate branches and PRs for them. Stuff does bitrot if it's not touched for a while... |
|
Thanks @takluyver, I successfully tested this PR on nbgrader. |
Member
Author
|
Thanks for checking! I'll tag a new version, it should get released to PyPI automatically. |
|
Thanks for the crazy-fast turnaround on this patch I tried to pre-empt the bot to get this into conda world as well: conda-forge/nbval-feedstock#15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202.
I've done this the simple way, which requires pytest >= 7. Pytest 7 came out over 2 years ago (February 2022), so I think it's reasonable for a new version of nbval to drop support for older versions.