Skip to content

Switch collection hook to use pathlib paths #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
takluyver merged 8 commits into from
Mar 4, 2024
Merged

Switch collection hook to use pathlib paths #203

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
76e052a
Switch collection hook to use pathlib paths
takluyver Mar 4, 2024
3581d24
Correct parameter name for hook
takluyver Mar 4, 2024
d8d7c01
Remove some more compatibility code for old pytest (versions < 6)
takluyver Mar 4, 2024
1d9f4db
Try to fix readthedocs build
takluyver Mar 4, 2024
8e3d157
Build docs with 'mambaforge-latest' Python
takluyver Mar 4, 2024
ba129a1
RTD needs the path to pip install
takluyver Mar 4, 2024
8248f58
Drop testing on Python 3.6
takluyver Mar 4, 2024
5f56fae
Install sphinx-rtd-theme for building docs
takluyver Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove some more compatibility code for old pytest (versions < 6)
  • Loading branch information
@takluyver
takluyver committed Mar 4, 2024
commit d8d7c01fb71fbdf4eebcdeb6a4bdbda731aadaae
10 changes: 3 additions & 7 deletions nbval/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,13 +344,9 @@ def collect(self):
options.update(comment_opts)
options.setdefault('check', self.compare_outputs)
name = 'Cell ' + str(cell_num)
# https://docs.pytest.org/en/stable/deprecations.html#node-construction-changed-to-node-from-parent
if hasattr(IPyNbCell, "from_parent"):
yield IPyNbCell.from_parent(
self, name=name, cell_num=cell_num, cell=cell, options=options
)
else:
yield IPyNbCell(name, self, cell_num, cell, options)
yield IPyNbCell.from_parent(
self, name=name, cell_num=cell_num, cell=cell, options=options
)

# Update 'code' cell count
cell_num += 1
Expand Down