-
Notifications
You must be signed in to change notification settings - Fork 3.2k
KIP-320 implementation #4162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KIP-320 implementation #4162
Conversation
…e object The on-demand glue object contains the previous rktp reference and a new leader_epoch field. This is for KIP-320
upgrading Metadata version to 9
is for each topic
Co-authored-by: Milind L <[email protected]>
6bf4056 to
4ac3733
Compare
4ac3733 to
80270ad
Compare
672824b to
774ae25
Compare
6c04083 to
5afd446
Compare
fcb8a73 to
cdb5340
Compare
offset validation, allows to retry the validation if needed
in this state
retry instead of refresh, same action as fenced leader epoch. The consumer could be fetching from a follower that is not in sync
using a fetch state check instead. Fix stale next fetch position update when fetch hasn't started yet
the log start offset
list, alter, delete consumer group offsets tests compare returned offsets and epochs
testing TxnOffsetCommit changes.
Mock handler for OffsetForLeaderEpoch Mock test for seek with leader epoch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished a first pass review for all the main parts of KIP-320. Mostly, it looks good to me. Just a few questions in the comments, especially one with reference to KIP-392 interaction with KIP-320.
The mock and test changes aren't a part of the review (and I have not yet made minor/nit comments).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it based on some internal discussion. I'll take a look once more but it seems fine to me.
Mainly, we discussed the comment about case3: the implementation in AK client is different from the KIP-392, and the same as here. I had made that comment based on the KIP. Things should be okay.
There are still some changes like log messages (minor) that @emasab is doing but those won't really block this PR from merging.
instead of fetch position
is found in OffsetForLeaderEpoch
Reopening with a different branch as CI only runs on feature branches