Skip to content

Refactor container_list_test.go to use Tigron #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 1 commit into from
Dec 8, 2025
Merged

Refactor container_list_test.go to use Tigron #4641

AkihiroSuda merged 1 commit into from
Dec 8, 2025
+54 −30

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Dec 8, 2025

Updates tests to use nerdtest.Setup and the Tigron testing framework as per issue #4613.

Used Gemini, with the following prompt

Work on https://github.com/containerd/nerdctl/issues/4613 for @cmd/nerdctl/container/container_list_test.go .

- Try to preserve the original test structure as much as possible.
- In Tigron, `t.Parallel()` does not need to be explicitly set. Refer to @docs/testing/tools.md for further information about Tigron.
- To run a test, use `go test -exec sudo -run <TESTNAME> <PACKAGE>`.

@AkihiroSuda
Refactor container_list_test.go to use Tigron
7e68e60 
Updates tests to use nerdtest.Setup and the Tigron testing framework
as per issue #4613.

Signed-off-by: Akihiro Suda <[email protected]>
@AkihiroSuda AkihiroSuda added this to the v2.2.1 (?) milestone Dec 8, 2025
@AkihiroSuda AkihiroSuda added the area/ci e.g., CI failure label Dec 8, 2025
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 8, 2025
Open
46 tasks
ChengyuZhu6
ChengyuZhu6 approved these changes Dec 8, 2025
View reviewed changes
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AkihiroSuda AkihiroSuda merged commit de8b1c9 into main Dec 8, 2025
36 checks passed
@AkihiroSuda AkihiroSuda deleted the dev-4613 branch December 8, 2025 06:46
@AkihiroSuda AkihiroSuda mentioned this pull request Dec 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ChengyuZhu6 ChengyuZhu6 ChengyuZhu6 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/ci e.g., CI failure

Projects

None yet

Milestone

v2.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@AkihiroSuda @ChengyuZhu6