Skip to content

Refactor container_list_test.go to use Tigron #4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AkihiroSuda merged 1 commit into from
Dec 8, 2025
Merged

Refactor container_list_test.go to use Tigron #4641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Refactor container_list_test.go to use Tigron 
Updates tests to use nerdtest.Setup and the Tigron testing framework
as per issue #4613.

Signed-off-by: Akihiro Suda <[email protected]>
  • Loading branch information
@AkihiroSuda
AkihiroSuda committed Dec 8, 2025
commit 7e68e60206ea0f4c26eecb9b666284bf836f1c2c
84 changes: 54 additions & 30 deletions cmd/nerdctl/container/container_list_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,43 +20,67 @@ import (
"fmt"
"testing"

"github.com/containerd/nerdctl/mod/tigron/expect"
"github.com/containerd/nerdctl/mod/tigron/test"

"github.com/containerd/nerdctl/v2/pkg/testutil"
"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
)

// https://github.com/containerd/nerdctl/issues/2598
func TestContainerListWithFormatLabel(t *testing.T) {
t.Parallel()
base := testutil.NewBase(t)
tID := testutil.Identifier(t)
cID := tID
labelK := "label-key-" + tID
labelV := "label-value-" + tID

base.Cmd("run", "-d",
"--name", cID,
"--label", labelK+"="+labelV,
testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
defer base.Cmd("rm", "-f", cID).AssertOK()
base.Cmd("ps", "-a",
"--filter", "label="+labelK,
"--format", fmt.Sprintf("{{.Label %q}}", labelK)).AssertOutExactly(labelV + "\n")
nerdtest.Setup()
testCase := &test.Case{
Setup: func(data test.Data, helpers test.Helpers) {
labelK := "label-key-" + data.Identifier()
labelV := "label-value-" + data.Identifier()
helpers.Ensure("run", "-d",
"--name", data.Identifier(),
"--label", labelK+"="+labelV,
testutil.CommonImage, "sleep", nerdtest.Infinity)
},
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier())
},
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
labelK := "label-key-" + data.Identifier()
return helpers.Command("ps", "-a",
"--filter", "label="+labelK,
"--format", fmt.Sprintf("{{.Label %q}}", labelK)) //nolint:dupামিটার
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
labelV := "label-value-" + data.Identifier()
return test.Expects(0, nil, expect.Equals(labelV+"\n"))(data, helpers)
},
}
testCase.Run(t)
}

func TestContainerListWithJsonFormatLabel(t *testing.T) {
t.Parallel()
base := testutil.NewBase(t)
tID := testutil.Identifier(t)
cID := tID
labelK := "label-key-" + tID
labelV := "label-value-" + tID

base.Cmd("run", "-d",
"--name", cID,
"--label", labelK+"="+labelV,
testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
defer base.Cmd("rm", "-f", cID).AssertOK()
base.Cmd("ps", "-a",
"--filter", "label="+labelK,
"--format", "json").AssertOutContains(fmt.Sprintf("%s=%s", labelK, labelV))
nerdtest.Setup()
testCase := &test.Case{
Setup: func(data test.Data, helpers test.Helpers) {
labelK := "label-key-" + data.Identifier()
labelV := "label-value-" + data.Identifier()
helpers.Ensure("run", "-d",
"--name", data.Identifier(),
"--label", labelK+"="+labelV,
testutil.CommonImage, "sleep", nerdtest.Infinity)
},
Cleanup: func(data test.Data, helpers test.Helpers) {
helpers.Anyhow("rm", "-f", data.Identifier())
},
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
labelK := "label-key-" + data.Identifier()
return helpers.Command("ps", "-a",
"--filter", "label="+labelK,
"--format", "json")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
labelK := "label-key-" + data.Identifier()
labelV := "label-value-" + data.Identifier()
return test.Expects(0, nil, expect.Contains(fmt.Sprintf("%s=%s", labelK, labelV)))(data, helpers)
},
}
testCase.Run(t)
}
Loading