feat:updated validation code and UI components related to upload #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayalijoshi27
requested changes
Apr 26, 2024
| // Filter CMS Data | ||
| const filterCMSData = (searchText: string) => { | ||
| const filterCMSData = async (searchText: string) => { | ||
| const { all_cms = [] } = migrationData.legacyCMSData; |
| <div className="col-12 mt-2"> | ||
| </div> */} | ||
| <div className="col-12"> | ||
| {validateArray(cmsData) ? ( |
Contributor
There was a problem hiding this comment.
Add validation for cmsData
| <Line type="solid" /> | ||
| </div> | ||
| <div className="col-12 mt-2"> | ||
| </div> */} |
Contributor
There was a problem hiding this comment.
Remove this commented code if not required
Contributor
Author
There was a problem hiding this comment.
kept for future use case ( as per my understanding if we are showing only the card for cms which user has given in config of upload service, then search will not be useful)
| }; | ||
|
|
||
| updateNewMigrationData(newMigrationDataObj); | ||
| console.log(newMigrationData); |
| <p className="summary-title">AWS Region: {fileDetails.awsData.awsRegion}</p> | ||
| <p className="summary-title">Bucket Name: {fileDetails.awsData.bucketName}</p> | ||
| <p className="summary-title">Bucket Key: {fileDetails.awsData.buketKey}</p> | ||
| </div> |
umeshmore45
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** UI **
++ select cms will display only a card of cms which user has given in config of upload seervice
++ upload component will display config details(filepath, aws details, validation message)
++if validation is successful then proceed to destination cta will be enable
++if validation unsuccessful then cta will be disabled
** Upload**
++ integrated and refactored latest code
++ added eslint config
++ refactored api response (irrespective of validation success, it will pass config details in response)