Skip to content

feat:updated validation code and UI components related to upload #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
umeshmore45 merged 2 commits into from
Apr 29, 2024
Merged

feat:updated validation code and UI components related to upload #71

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e363d08
feat:updated validation code and UI components related to upload
AishDani Apr 26, 2024
bd87308
refactor: PR comments
AishDani Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: PR comments
  • Loading branch information
@AishDani
AishDani committed Apr 29, 2024
commit bd87308f34ed48ae46da6f83bf4dd60ca4b5b40f
4 changes: 2 additions & 2 deletions ui/src/components/LegacyCms/Actions/LoadSelectCms.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const LoadSelectCms = (props: LoadSelectCmsProps) => {
}
// Filter CMS Data
const filterCMSData = async (searchText: string) => {
const { all_cms = [] } = migrationData.legacyCMSData;
const { all_cms = [] } = migrationData?.legacyCMSData || {};
const cmsType = await getCmsType(); // Fetch the specific CMS type

let filteredCmsData: ICMSType[] = [];
Expand Down Expand Up @@ -186,7 +186,7 @@ const LoadSelectCms = (props: LoadSelectCmsProps) => {
<Line type="solid" />
</div> */}
Copy link
Contributor

@sayalijoshi27 sayalijoshi27 Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this commented code if not required

Copy link
Contributor Author

@AishDani AishDani Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kept for future use case ( as per my understanding if we are showing only the card for cms which user has given in config of upload service, then search will not be useful)

<div className="col-12">
{validateArray(cmsData) ? (
{cmsData && validateArray(cmsData) ? (
<div className="service_list">
{cmsData?.map((data: ICMSType) => (
<Card
Expand Down
1 change: 0 additions & 1 deletion ui/src/components/LegacyCms/Actions/LoadUploadFile.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ const LoadUploadFile = (props: LoadUploadFileProps) => {
}
}
updateNewMigrationData(newMigrationDataObj);
console.log(newMigrationData);


props.handleStepChange(props.currentStep, true);
Expand Down
12 changes: 6 additions & 6 deletions ui/src/components/LegacyCms/Summary/UploadFileSummary.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ interface Props {
const FileComponent : React.FC<Props>= ({fileDetails}) => {
return (
<div className='col-11'>
<p className="summary-title">Is Local Path: {fileDetails.isLocalPath ? 'Yes' : 'No'}</p>
<p className="summary-title">CMS Type: {fileDetails.cmsType}</p>
<p className="summary-title">Local Path: {fileDetails.localPath}</p>
<p className="summary-title">AWS Region: {fileDetails.awsData.awsRegion}</p>
<p className="summary-title">Bucket Name: {fileDetails.awsData.bucketName}</p>
<p className="summary-title">Bucket Key: {fileDetails.awsData.buketKey}</p>
<p className="summary-title">Is Local Path: {fileDetails?.isLocalPath ? 'Yes' : 'No'}</p>
<p className="summary-title">CMS Type: {fileDetails?.cmsType}</p>
<p className="summary-title">Local Path: {fileDetails?.localPath}</p>
<p className="summary-title">AWS Region: {fileDetails?.awsData?.awsRegion}</p>
<p className="summary-title">Bucket Name: {fileDetails?.awsData?.bucketName}</p>
<p className="summary-title">Bucket Key: {fileDetails?.awsData?.buketKey}</p>
</div>
Copy link
Contributor

@sayalijoshi27 sayalijoshi27 Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add validation

Copy link
Contributor Author

@AishDani AishDani Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

);

Expand Down