Skip to content

chore: enable typescript error on unused locals #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2020
Merged

chore: enable typescript error on unused locals #938

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d534b6c
chore: enable typescript error on unused locals
armano2 Feb 4, 2020
23ad9d6
Merge branch 'master' into no-unused-locals
armano2 Feb 4, 2020
5c8bb52
chore: add more typescript compiler flags
armano2 Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: enable typescript error on unused locals
  • Loading branch information
@armano2
armano2 committed Feb 4, 2020
commit d534b6ce75ec7b8eca75712878283f8b970826b3
2 changes: 1 addition & 1 deletion @commitlint/resolve-extends/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ function getId(raw: string = '', prefix: string = ''): string {
return relative || absolute ? raw : [prefix, raw].filter(String).join('-');
}

function resolveConfig<T>(
function resolveConfig(
raw: string,
context: ResolveExtendsContext = {}
): string {
Expand Down
5 changes: 4 additions & 1 deletion tsconfig.shared.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
"module": "commonjs",
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true
"strict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"noUnusedLocals": true
}
}