feat(svg): add an interval prop #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an interval prop that controls the duration of the interval between two animations. For instance, an interval of `.25` and an animation speed of `2` imply that the animation will take 1.5s to complete, and wait 0.5s before starting again.
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
==========================================
+ Coverage 96.77% 96.92% +0.14%
==========================================
Files 9 9
Lines 62 65 +3
Branches 9 9
==========================================
+ Hits 60 63 +3
Partials 2 2
Continue to review full report at Codecov.
|
|
I've found that the current animation has an interval comprising of 25% of its actual duration (or |
This was referenced Mar 3, 2019
danilowoz
approved these changes
Mar 6, 2019
|
🎉 This PR is included in version 4.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add an interval prop that controls the duration of the interval between two animations. For
instance, an interval of
.25and an animation speed of2imply that the animation willtake 1.5s to complete, and wait 0.5s before starting again.
Any Breaking Changes
None; snapshots have changed but the addition of the
keyTimesattribute make the resulting animations equivalent.Checklist