Feature to fetch temporary object store credentials #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joyceyuu
reviewed
Apr 22, 2020
Contributor
joyceyuu
left a comment
joyceyuu
left a comment
There was a problem hiding this comment.
Look good overall. If you can answer my few questions, I am happy to approve it
| out = combine_clks_blocks(clk_json, blocks) | ||
| with open(clk_json, 'rb') as encodings: | ||
| out = combine_clks_blocks(encodings, blocks) | ||
| response = rest_client.project_upload_clks(project, apikey, out) |
Contributor
There was a problem hiding this comment.
Why we don't upload to minio as well like the no blocking case?
Collaborator
Author
There was a problem hiding this comment.
In the initial plan we will only support binary encodings being uploaded to the object store. Eventually a binary format for the blocks will also be implemented.
joyceyuu
approved these changes
Apr 22, 2020
Contributor
joyceyuu
left a comment
joyceyuu
left a comment
There was a problem hiding this comment.
Look good to me. Just few tests are currently failing. Maybe merge into master after fixing the tests
Codecov Report
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
+ Coverage 91.44% 94.67% +3.22%
==========================================
Files 3 3
Lines 456 488 +32
==========================================
+ Hits 417 462 +45
+ Misses 39 26 -13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the cli client to retrieve object store credentials during upload.
For testing purposes it uploads the data twice - once to the existing api, and once to the object store.