Expose minio #548
Merged
Expose minio #548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update documentation in values file.
wilko77
approved these changes
Apr 27, 2020
| config.UPLOAD_OBJECT_STORE_SERVER, | ||
| config.UPLOAD_OBJECT_STORE_ACCESS_KEY, | ||
| config.UPLOAD_OBJECT_STORE_SECRET_KEY, | ||
| region="us-east-1", |
Collaborator
There was a problem hiding this comment.
why is region hard-coded when everything else is configurable?
Collaborator
Author
There was a problem hiding this comment.
It could be configurable but we'd probably have to introduce another minio/boto client just to connect to us-east-1 for the granting the temporary credentials.
Comment on lines
12
to
14
| ## Disable the feature providing client's with restricted upload access to the object store. | ||
| ## By default we don't expose the Minio object store, however it needs to be exposed when | ||
| ## enabling this feature. See section `minio.ingress`. |
Collaborator
There was a problem hiding this comment.
I don't understand this comment. So what do I have to set this to to enable client upload to our Minio object store?
Collaborator
Author
There was a problem hiding this comment.
I'll clarify this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is mostly around the kubernetes deployment of minio it builds on #547 .
secureconnectionOther than the e2e tests I've also drafted a branch of anonlink-client which uses a deployment of this expose-minio branch to fetch credentials and upload data directly to the object store.