Revive jaeger #500
Merged
Revive jaeger #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilko77
approved these changes
Feb 12, 2020
Collaborator
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
the config restructuring looks good from a high level.
| load_yaml_config(filename) | ||
|
|
||
| def test_random_bytes(self): | ||
| with temp_file_containing(generate_bytes(128)) as fp: |
Collaborator
There was a problem hiding this comment.
there is a non-zero chance that those random bytes resemble valid yaml. Why not just feeding a known invalid config to the test?
backend/entityservice/tests/util.py
Outdated
|
|
||
| @contextmanager | ||
| def temp_file_containing(data): | ||
| # Code to acquire resource, e.g.: |
Collaborator
There was a problem hiding this comment.
that is not a very useful comment
backend/entityservice/utils.py
Outdated
| with open(filename, 'rt') as f: | ||
| return yaml.safe_load(f) | ||
| except UnicodeDecodeError as e: | ||
| raise InvalidConfiguration("YAML file appears corrupt") from e |
Collaborator
There was a problem hiding this comment.
it would be nice to include the filename in the error message.
Expose LOG_CFG variable via settings.py like all other env vargs
hardbyte
force-pushed
the
revive-jaeger
branch
from
6f38bc0 to
5439e49
Compare
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings Jaeger/opentracing support back to life.
Refactors some of the logging config to be reused in the tracing config. I just pulled out the yaml config file loader and added tests.
Restructures the config via k8s to be a bit simpler - now all monitoring related config files are mounted in
/var/config, the filenames are still passed in via ENV vars.The default
values.yamlfile for our helm chart now includes annotations that will enable opentracing via a jaeger sidecar - if the cluster supports it. It has no effect on clusters that don't have jaeger enabled so I don't think it is a big deal to enable by default.I uncommented the logging config in the values.yaml file so it is actually tested/used. It needs improvement.