Skip to content

Revive jaeger #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardbyte merged 22 commits into from
Feb 14, 2020
Merged

Revive jaeger #500

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
06a6f36
Allow user to provide arbitrary config
hardbyte Feb 11, 2020
fac1c23
Allow user to provide arbitrary deployment annotations
hardbyte Feb 11, 2020
b1441a9
Try use default tracing connection
hardbyte Feb 11, 2020
5a7583a
Use default tracing connection for api too
hardbyte Feb 11, 2020
292e46a
Extract load_yaml_config from setup_logging and add tests
hardbyte Feb 11, 2020
4fb2578
K8s: Add a config file for tracing. Always mount all config files in …
hardbyte Feb 11, 2020
cea3bb7
Remove redundant helper function from test_serialization
hardbyte Feb 11, 2020
f87a2ca
Remove individual tracing setting in favor of passing in a file path.
hardbyte Feb 11, 2020
f5f8aad
Use tracing config file or default
hardbyte Feb 11, 2020
e6a2f5a
Strings to yaml not objects
hardbyte Feb 12, 2020
39df146
Add config volume to db init job
hardbyte Feb 12, 2020
5b4316d
Try to use jaeger during CI testing for api
hardbyte Feb 12, 2020
4548c59
Use default tracing connection for workers
hardbyte Feb 12, 2020
f5a6677
Try enable tracing
hardbyte Feb 12, 2020
bedc79a
Use default tracing connection for api too
hardbyte Feb 12, 2020
083affb
Ok enough of azure, just enable the tracing annotation by default
hardbyte Feb 12, 2020
2f2b7e2
Use default logging config in k8s
hardbyte Feb 12, 2020
729032f
fix filename typo
hardbyte Feb 12, 2020
5439e49
cleanup after review
hardbyte Feb 12, 2020
278cccd
Only log celery container from worker pod
hardbyte Feb 12, 2020
b563cb4
Remove a stray print statement
hardbyte Feb 13, 2020
95ff98c
Minor tweaks to improve logging
hardbyte Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use default tracing connection for workers
  • Loading branch information
@hardbyte
hardbyte committed Feb 12, 2020
commit 4548c59e8e912a65519b0f15f488668ddeec954f
1 change: 1 addition & 0 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,6 +206,7 @@ stages:
api.dbinit.image.repository:$(backendImageName)
workers.image.repository:$(backendImageName)
api.deploymentAnnotations."sidecar.jaegertracing.io/inject":"true"
workers.deploymentAnnotations."sidecar.jaegertracing.io/inject":"true"

- task: KubernetesManifest@0
displayName: Deploy K8s manifest
Expand Down
1 change: 0 additions & 1 deletion backend/entityservice/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ def get_tracer_config(service_name):
tracing_config = load_yaml_config(config.TRACING_CONFIG_FILENAME)
else:
tracing_config = DEFAULT_TRACER_CONFIG

return jaeger_client.Config(config=tracing_config, service_name=service_name)


Expand Down