Feature blocking #510
Merged
Feature blocking #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
force-pushed
the
feature-blocking
branch
from
66e4c3a to
3fccff0
Compare
hardbyte
force-pushed
the
feature-blocking
branch
from
3fccff0 to
9338c9c
Compare
added 7 commits
February 20, 2020 13:22
…st known good version
wilko77
approved these changes
Feb 21, 2020
Collaborator
wilko77
left a comment
wilko77
left a comment
There was a problem hiding this comment.
the deletion of the tempfile should be sorted though. Otherwise it's fine.
| safe_fail_request(400, message='Missing CLK and Blocks information') | ||
| # fail condition5 - unknown element in JSON | ||
| if 'clks' not in clk_json and 'clknblocks' not in clk_json: | ||
| safe_fail_request(400, message='Unknown upload element - expect "clks" or "clknblocks"') |
Collaborator
There was a problem hiding this comment.
if this function would throw an exception instead of calling safe_fail_request it would be nicely unit-testable.
| raise ValueError('can only handle CLKs at the moment.') | ||
| binary_data = b'\n'.join(''.join(clk.split('\n')).encode() for clk in data['clks']) + b'\n' | ||
| buffer = io.BytesIO(binary_data) | ||
| #### END GLUE |
Collaborator
There was a problem hiding this comment.
This is the most beautiful glue code I have ever seen.
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #503. I can't review because I opened this PR.