-
Notifications
You must be signed in to change notification settings - Fork 8
Feature blocking #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feature blocking #510
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
1c9e562
Extend upload endpoint to accept both types - clks and clknblocks
joyceyuu 188465d
Integrate feedback from Brian
joyceyuu 7dc9832
Remove get_uses_blocking and use NamedTempFile
joyceyuu d1bde89
added doc string
8d29780
updated docstring, rearranged arguments
9338c9c
Log the number of elements and number of blocks in json upload
hardbyte 7d06dba
Glue code to make tests pass again
675b434
bugfix json wasn't always fully written to disk
479a284
didn't want to commit that, sorry
9daa497
trying to handle empty uploads
9988af2
revived test for empty upload
456e2c6
tornado 6 is incompatible to other requirements, thus backtrack to la…
00e247c
fix test condition
13a5912
Raise valueError when upload is not valid to separate our code from n…
joyceyuu File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Log the number of elements and number of blocks in json upload
- Loading branch information
commit 9338c9c24cb75c4e872a002c7d972c92ff8d91e4
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.