Skip to content

fix(ingest): use looker data platform #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Jun 16, 2021
Merged

fix(ingest): use looker data platform #2708

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
619fc98
fix(ingest): use `looker` data platform everywhere
hsheth2 Jun 16, 2021
1bcb362
add looker data platform
hsheth2 Jun 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(ingest): use looker data platform everywhere
  • Loading branch information
@hsheth2
hsheth2 committed Jun 16, 2021
commit 619fc98390633a0f4ab43d405221d80966ae2e6e
4 changes: 3 additions & 1 deletion metadata-ingestion/scripts/update_golden_files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ cp tmp/test_mysql_ingest0/mysql_mces.json tests/integration/mysql/mysql_mce_gold
cp tmp/test_mssql_ingest0/mssql_mces.json tests/integration/sql_server/mssql_mce_golden.json
cp tmp/test_mongodb_ingest0/mongodb_mces.json tests/integration/mongodb/mongodb_mce_golden.json
cp tmp/test_feast_ingest0/feast_mces.json tests/integration/feast/feast_mce_golden.json
cp tmp/test_lookml_ingest0/lookml_mces.json tests/integration/lookml/expected_output.json
cp tmp/test_looker_ingest0/looker_mces.json tests/integration/looker/expected_output.json

# Print success message.
set +x
echo ''
echo 'Make sure to check `git diff` to verify the changes!'
echo 'Make sure to check `git diff -w` to verify the changes!'
2 changes: 0 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/looker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ class LookerDashboardSourceConfig(ConfigModel):
client_secret: str
base_url: str
platform_name: str = "looker"
# The datahub platform where looker views are stored, must be the same as `platform_name` in lookml source
view_platform_name: str = "looker_views"
actor: str = "urn:li:corpuser:etl"
dashboard_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
chart_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/lookml.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
class LookMLSourceConfig(ConfigModel): # pragma: no cover
base_folder: str
connection_to_platform_map: Dict[str, str]
platform_name: str = "looker_views"
platform_name: str = "looker"
actor: str = "urn:li:corpuser:etl"
model_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
view_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
Expand Down
170 changes: 85 additions & 85 deletions metadata-ingestion/tests/integration/looker/expected_output.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,98 +1,98 @@
[
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.ChartSnapshot": {
"urn": "urn:li:chart:(looker,dashboard_elements.2)",
"aspects": [
{
"com.linkedin.pegasus2avro.chart.ChartInfo": {
"customProperties": {},
"externalUrl": null,
"title": "",
"description": "Some text",
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.ChartSnapshot": {
"urn": "urn:li:chart:(looker,dashboard_elements.2)",
"aspects": [
{
"com.linkedin.pegasus2avro.chart.ChartInfo": {
"customProperties": {},
"externalUrl": null,
"title": "",
"description": "Some text",
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"chartUrl": "https://looker.company.com/x/",
"inputs": [],
"type": null,
"access": null,
"lastRefreshed": null
}
"deleted": null
},
"chartUrl": "https://looker.company.com/x/",
"inputs": [],
"type": null,
"access": null,
"lastRefreshed": null
}
]
}
},
"proposedDelta": null
}
]
}
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DashboardSnapshot": {
"urn": "urn:li:dashboard:(looker,dashboards.1)",
"aspects": [
{
"com.linkedin.pegasus2avro.dashboard.DashboardInfo": {
"customProperties": {},
"externalUrl": null,
"title": "foo",
"description": "lorem ipsum",
"charts": [
"urn:li:chart:(looker,dashboard_elements.2)"
],
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
"proposedDelta": null
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DashboardSnapshot": {
"urn": "urn:li:dashboard:(looker,dashboards.1)",
"aspects": [
{
"com.linkedin.pegasus2avro.dashboard.DashboardInfo": {
"customProperties": {},
"externalUrl": null,
"title": "foo",
"description": "lorem ipsum",
"charts": [
"urn:li:chart:(looker,dashboard_elements.2)"
],
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"dashboardUrl": "https://looker.company.com/dashboards/1",
"access": null,
"lastRefreshed": null
}
},
{
"com.linkedin.pegasus2avro.common.Ownership": {
"owners": [
{
"owner": "urn:li:corpuser:etl",
"type": "DATAOWNER",
"source": null
}
],
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
},
"dashboardUrl": "https://looker.company.com/dashboards/1",
"access": null,
"lastRefreshed": null
}
},
{
"com.linkedin.pegasus2avro.common.Ownership": {
"owners": [
{
"owner": "urn:li:corpuser:etl",
"type": "DATAOWNER",
"source": null
}
}
},
{
"com.linkedin.pegasus2avro.common.Status": {
"removed": false
],
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
}
}
]
}
},
"proposedDelta": null
}
]
},
{
"com.linkedin.pegasus2avro.common.Status": {
"removed": false
}
}
]
}
},
"proposedDelta": null
}
]
Loading