Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions gms/impl/src/main/resources/DataPlatformInfo.json
Original file line number Diff line number Diff line change
Expand Up @@ -156,5 +156,12 @@
"displayName": "Druid",
"type": "OLAP_DATASTORE",
"logoUrl": "https://raw.githubusercontent.com/linkedin/datahub/master/datahub-web-react/src/images/druidlogo.png"
},
"urn:li:dataPlatform:looker": {
"datasetNameDelimiter": ".",
"name": "looker",
"displayName": "Looker",
"type": "OTHERS",
"logoUrl": "https://raw.githubusercontent.com/linkedin/datahub/master/datahub-web-react/src/images/lookerlogo.png"
}
}
20 changes: 20 additions & 0 deletions metadata-ingestion/examples/mce_files/bootstrap_mce.json
Original file line number Diff line number Diff line change
Expand Up @@ -1880,5 +1880,25 @@
}
},
"proposedDelta": null
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DataPlatformSnapshot": {
"urn": "urn:li:dataPlatform:looker",
"aspects": [
{
"com.linkedin.pegasus2avro.dataplatform.DataPlatformInfo": {
"datasetNameDelimiter": ".",
"name": "looker",
"displayName": "Looker",
"type": "OTHERS",
"logoUrl": "https://raw.githubusercontent.com/linkedin/datahub/master/datahub-web-react/src/images/lookerlogo.png"
}
}
]
}
},
"proposedDelta": null
}
]
22 changes: 21 additions & 1 deletion metadata-ingestion/examples/mce_files/data_platforms.json
Original file line number Diff line number Diff line change
Expand Up @@ -455,5 +455,25 @@
}
},
"proposedDelta": null
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DataPlatformSnapshot": {
"urn": "urn:li:dataPlatform:looker",
"aspects": [
{
"com.linkedin.pegasus2avro.dataplatform.DataPlatformInfo": {
"datasetNameDelimiter": ".",
"name": "looker",
"displayName": "Looker",
"type": "OTHERS",
"logoUrl": "https://raw.githubusercontent.com/linkedin/datahub/master/datahub-web-react/src/images/lookerlogo.png"
}
}
]
}
},
"proposedDelta": null
}
]
]
4 changes: 3 additions & 1 deletion metadata-ingestion/scripts/update_golden_files.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ cp tmp/test_mysql_ingest0/mysql_mces.json tests/integration/mysql/mysql_mce_gold
cp tmp/test_mssql_ingest0/mssql_mces.json tests/integration/sql_server/mssql_mce_golden.json
cp tmp/test_mongodb_ingest0/mongodb_mces.json tests/integration/mongodb/mongodb_mce_golden.json
cp tmp/test_feast_ingest0/feast_mces.json tests/integration/feast/feast_mce_golden.json
cp tmp/test_lookml_ingest0/lookml_mces.json tests/integration/lookml/expected_output.json
cp tmp/test_looker_ingest0/looker_mces.json tests/integration/looker/expected_output.json

# Print success message.
set +x
echo ''
echo 'Make sure to check `git diff` to verify the changes!'
echo 'Make sure to check `git diff -w` to verify the changes!'
2 changes: 0 additions & 2 deletions metadata-ingestion/src/datahub/ingestion/source/looker.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,6 @@ class LookerDashboardSourceConfig(ConfigModel):
client_secret: str
base_url: str
platform_name: str = "looker"
# The datahub platform where looker views are stored, must be the same as `platform_name` in lookml source
view_platform_name: str = "looker_views"
actor: str = "urn:li:corpuser:etl"
dashboard_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
chart_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
Expand Down
2 changes: 1 addition & 1 deletion metadata-ingestion/src/datahub/ingestion/source/lookml.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
class LookMLSourceConfig(ConfigModel): # pragma: no cover
base_folder: str
connection_to_platform_map: Dict[str, str]
platform_name: str = "looker_views"
platform_name: str = "looker"
actor: str = "urn:li:corpuser:etl"
model_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
view_pattern: AllowDenyPattern = AllowDenyPattern.allow_all()
Expand Down
170 changes: 85 additions & 85 deletions metadata-ingestion/tests/integration/looker/expected_output.json
Original file line number Diff line number Diff line change
@@ -1,98 +1,98 @@
[
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.ChartSnapshot": {
"urn": "urn:li:chart:(looker,dashboard_elements.2)",
"aspects": [
{
"com.linkedin.pegasus2avro.chart.ChartInfo": {
"customProperties": {},
"externalUrl": null,
"title": "",
"description": "Some text",
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.ChartSnapshot": {
"urn": "urn:li:chart:(looker,dashboard_elements.2)",
"aspects": [
{
"com.linkedin.pegasus2avro.chart.ChartInfo": {
"customProperties": {},
"externalUrl": null,
"title": "",
"description": "Some text",
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"chartUrl": "https://looker.company.com/x/",
"inputs": [],
"type": null,
"access": null,
"lastRefreshed": null
}
"deleted": null
},
"chartUrl": "https://looker.company.com/x/",
"inputs": [],
"type": null,
"access": null,
"lastRefreshed": null
}
]
}
},
"proposedDelta": null
}
]
}
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DashboardSnapshot": {
"urn": "urn:li:dashboard:(looker,dashboards.1)",
"aspects": [
{
"com.linkedin.pegasus2avro.dashboard.DashboardInfo": {
"customProperties": {},
"externalUrl": null,
"title": "foo",
"description": "lorem ipsum",
"charts": [
"urn:li:chart:(looker,dashboard_elements.2)"
],
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
"proposedDelta": null
},
{
"auditHeader": null,
"proposedSnapshot": {
"com.linkedin.pegasus2avro.metadata.snapshot.DashboardSnapshot": {
"urn": "urn:li:dashboard:(looker,dashboards.1)",
"aspects": [
{
"com.linkedin.pegasus2avro.dashboard.DashboardInfo": {
"customProperties": {},
"externalUrl": null,
"title": "foo",
"description": "lorem ipsum",
"charts": [
"urn:li:chart:(looker,dashboard_elements.2)"
],
"lastModified": {
"created": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"dashboardUrl": "https://looker.company.com/dashboards/1",
"access": null,
"lastRefreshed": null
}
},
{
"com.linkedin.pegasus2avro.common.Ownership": {
"owners": [
{
"owner": "urn:li:corpuser:etl",
"type": "DATAOWNER",
"source": null
}
],
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
},
"deleted": null
},
"dashboardUrl": "https://looker.company.com/dashboards/1",
"access": null,
"lastRefreshed": null
}
},
{
"com.linkedin.pegasus2avro.common.Ownership": {
"owners": [
{
"owner": "urn:li:corpuser:etl",
"type": "DATAOWNER",
"source": null
}
}
},
{
"com.linkedin.pegasus2avro.common.Status": {
"removed": false
],
"lastModified": {
"time": 1615443388000,
"actor": "urn:li:corpuser:etl",
"impersonator": null
}
}
]
}
},
"proposedDelta": null
}
]
},
{
"com.linkedin.pegasus2avro.common.Status": {
"removed": false
}
}
]
}
},
"proposedDelta": null
}
]
Loading