Skip to content

fix(superset): handle dashboards without charts (#3713) #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shirshanka merged 2 commits into from
Dec 13, 2021
Merged

fix(superset): handle dashboards without charts (#3713) #3714

shirshanka merged 2 commits into from
Dec 13, 2021

Conversation

@grumbler
Copy link
Contributor

@grumbler grumbler commented Dec 10, 2021

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable)

gabe-lyons
gabe-lyons approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix-- this looks good for my end

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2021 •
edited
Loading

Unit Test Results

     44 files  ±  0       44 suites  ±0   40m 12s ⏱️ +36s
   628 tests +  5     576 ✔️ +  5  52 💤 ±0  0 ❌ ±0 
1 412 runs  +25  1 344 ✔️ +25  68 💤 ±0  0 ❌ ±0 

Results for commit 5673c66. ± Comparison against base commit 1f1467a.

♻️ This comment has been updated with latest results.

shirshanka
shirshanka approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@shirshanka shirshanka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shirshanka shirshanka merged commit 83207b3 into datahub-project:master Dec 13, 2021
@shirshanka shirshanka mentioned this pull request Dec 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shirshanka shirshanka shirshanka approved these changes

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@grumbler @shirshanka @gabe-lyons