Skip to content

fix(superset): handle dashboards without charts (#3713) #3714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shirshanka merged 2 commits into from
Dec 13, 2021
Merged

fix(superset): handle dashboards without charts (#3713) #3714

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f7d4a6
fix(superset): handle dashboards without charts (#3713)
grumbler Dec 10, 2021
5673c66
making lint happy
shirshanka Dec 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
making lint happy
  • Loading branch information
@shirshanka
shirshanka authored Dec 13, 2021
commit 5673c66d94217cad21b17a241dc0ab21f01d345a
4 changes: 3 additions & 1 deletion metadata-ingestion/src/datahub/ingestion/source/superset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,9 @@ def construct_dashboard_from_api_data(self, dashboard_data):

chart_urns = []
raw_position_data = dashboard_data.get("position_json", "{}")
position_data = json.loads(raw_position_data) if raw_position_data is not None else {}
position_data = (
json.loads(raw_position_data) if raw_position_data is not None else {}
)
for key, value in position_data.items():
if not key.startswith("CHART-"):
continue
Expand Down