dropped support for Python 3.4

.travis.yml

@@ -4,7 +4,6 @@ language: python
 env:
   - DJ_TEST_HOST="127.0.0.1" DJ_TEST_USER="datajoint" DJ_TEST_PASSWORD="datajoint" DJ_HOST="127.0.0.1" DJ_USER="root" DJ_PASS="" S3_ACCESS_KEY="datajoint" S3_SECRET_KEY="datajoint"
 python:
-  - "3.4"
   - "3.5"
   - "3.6"
   - "3.7"

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Release notes
 
 ### 0.12.0 -- Aug 23, 2019
+* Dropped support for Python 3.4
 * Support TLS/SSL connections PR #620
 * Convert numpy array from python object to appropriate data type if all elements are of the same type (#587) PR #608
 * Remove expression requirement to have additional attributes (#604) PR #604

datajoint/external.py

@@ -109,8 +109,7 @@ def _download_buffer(self, external_path):
         if self.spec['protocol'] == 's3':
             return self.s3.get(external_path)
         if self.spec['protocol'] == 'file':
-            with Path(external_path).open('rb') as f:
-                return f.read()
+            return Path(external_path).read_bytes()
         assert False
 
     def _remove_external_file(self, external_path):
@@ -157,8 +156,7 @@ def get(self, uuid):
             try:
                 cache_path = Path(cache_folder, *subfold(uuid.hex, CACHE_SUBFOLDING))
                 cache_file = Path(cache_path, uuid.hex)
-                with cache_file.open('rb') as f:
-                    blob = f.read()
+                blob = cache_file.read_bytes()
             except FileNotFoundError:
                 pass  # not cached
         # download blob from external store

datajoint/table.py

@@ -277,8 +277,7 @@ def make_placeholder(name, value):
                             value = self.external[attr.store].upload_attachment(attachment_path).bytes
                         else:
                             # value is filename + contents
-                            with attachment_path.open('rb') as f:
-                                value = str.encode(attachment_path.name) + b'\0' + f.read()
+                            value = str.encode(attachment_path.name) + b'\0' + attachment_path.read_bytes()
                     elif attr.is_filepath:
                         value = self.external[attr.store].upload_filepath(value).bytes
                     elif attr.numeric:

datajoint/utils.py

@@ -82,8 +82,7 @@ def safe_write(filepath, blob):
     if not filepath.is_file():
         filepath.parent.mkdir(parents=True, exist_ok=True)
         temp_file = filepath.with_suffix(filepath.suffix + '.saving')
-        with temp_file.open('wb') as f:
-            f.write(blob)
+        temp_file.write_bytes(blob)
         temp_file.rename(filepath)