-
Notifications
You must be signed in to change notification settings - Fork 90
Store attachments as intact files #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+519
−475
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
bcfb173
attachments are saved as intact files
dimitri-yatsenko 18366e6
reform attachments and filepath
dimitri-yatsenko 11d7d9b
complete implementation of external storage except for `clean`
dimitri-yatsenko 22347ae
Merge branch 'dev' of https://github.com/datajoint/datajoint-python i…
dimitri-yatsenko 7e7c183
refactor external storage
dimitri-yatsenko 8aa1543
complete refactoring of external storage for version 0.12
dimitri-yatsenko a2d6f9a
rename attribute `basename` to `attachment_name` in external table
dimitri-yatsenko 2c11a65
add __repr__ to ExternalMapping
dimitri-yatsenko 3a1c6ab
external files are not copied if stage and store are the same
dimitri-yatsenko 478b36a
make external tables require setting the `delete_external_files` argu…
dimitri-yatsenko bb1deab
update CHANGELOG
dimitri-yatsenko e2636ed
fix Python 3.4 compatibility
dimitri-yatsenko 11a1f93
fix Python 3.4 and 3.5 compatibility
dimitri-yatsenko 165f795
dropped support for Python 3.4
dimitri-yatsenko c18af74
Merge branch 'dev' of https://github.com/datajoint/datajoint-python i…
dimitri-yatsenko 48147f1
minor changes in error messages
dimitri-yatsenko 2e26c4a
Merge branch 'dev' of https://github.com/datajoint/datajoint-python i…
dimitri-yatsenko 0c4fd1c
Update to pathlib in test init.
guzman-raphael 6ba86e0
Update test_blob_migrate to be compatible for WIN10.
guzman-raphael 43a5126
Fix WIN10 compatibility with KeyboardInterrupt and SystemExit excepti…
guzman-raphael c7ca34c
Merge pull request #4 from guzman-raphael/dimitri-attach
dimitri-yatsenko 5c99e37
Fix WIN10 filepath to store as posix and fetch as user's platform.
guzman-raphael e2c3f23
Fix relpath for Python3.5.
guzman-raphael 93aeefc
Fix copytree for Python3.5.
guzman-raphael 20719ae
Fix typo.
guzman-raphael 7ca0099
Fix for Python3.5.
guzman-raphael f3ffd63
Update coveralls.
guzman-raphael bb1b40f
Update coverall env vars.
guzman-raphael f05c50d
Merge pull request #5 from guzman-raphael/win-filepath
dimitri-yatsenko 298efed
add environment variable DJ_SUPPORT_FILEPATH_MANAGEMENT to enable/dis…
dimitri-yatsenko e609fbe
Merge branch 'attach' of https://github.com/dimitri-yatsenko/datajoin…
dimitri-yatsenko 6dda528
Update CHANGELOG.md
dimitri-yatsenko 796dae6
Update CHANGELOG.md
dimitri-yatsenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Merge branch 'dev' of https://github.com/datajoint/datajoint-python i…
…nto attach
- Loading branch information
commit 2e26c4a62c7024351e771199934ab711027f4da0
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,73 @@ | ||
| sudo: required | ||
| env: | ||
| - DJ_TEST_HOST="127.0.0.1" DJ_TEST_USER="datajoint" DJ_TEST_PASSWORD="datajoint" DJ_HOST="127.0.0.1" DJ_USER="root" DJ_PASS="" S3_ACCESS_KEY="datajoint" S3_SECRET_KEY="datajoint" | ||
| python: | ||
| - "3.5" | ||
| - "3.6" | ||
| - "3.7" | ||
| services: | ||
| - mysql | ||
| - docker | ||
| before_install: | ||
| - sudo apt-get -qq update | ||
| - docker pull minio/minio | ||
| - docker run -d -p 9000:9000 -e "MINIO_ACCESS_KEY=$S3_ACCESS_KEY" -e "MINIO_SECRET_KEY=$S3_SECRET_KEY" minio/minio server /data | ||
| - sleep 120 | ||
| - sudo apt-get install -y libblas-dev liblapack-dev libatlas-dev gfortran | ||
| - sudo apt-get install -y graphviz graphviz-dev pkg-config | ||
| - mysql --version | ||
| install: | ||
| - travis_wait 30 pip install -r requirements.txt | ||
| - travis_wait 30 pip install -r test_requirements.txt | ||
| - pip install nose nose-cov python-coveralls | ||
| # command to run tests | ||
| script: | ||
| - nosetests -vv --with-coverage --cover-package=datajoint | ||
|
|
||
| after_success: | ||
| - coveralls | ||
| global: | ||
| - MINIO_VER="RELEASE.2019-09-26T19-42-35Z" | ||
| - ALPINE_VER="3.10" | ||
| - COMPOSE_HTTP_TIMEOUT="300" | ||
| - UID="2000" | ||
| - GID="2000" | ||
| services: | ||
| - docker | ||
| main: &main | ||
| stage: Alpine | ||
| os: linux | ||
| language: shell | ||
| script: | ||
| - docker-compose -f LNX-docker-compose.yml up --build --exit-code-from dj | ||
| jobs: | ||
| include: | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.8-rc" | ||
| - MYSQL_VER: "5.7" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.7" | ||
| - MYSQL_VER: "5.7" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.6" | ||
| - MYSQL_VER: "5.7" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.5" | ||
| - MYSQL_VER: "5.7" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.8-rc" | ||
| - MYSQL_VER: "8.0" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.7" | ||
| - MYSQL_VER: "8.0" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.6" | ||
| - MYSQL_VER: "8.0" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.5" | ||
| - MYSQL_VER: "8.0" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.8-rc" | ||
| - MYSQL_VER: "5.6" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.7" | ||
| - MYSQL_VER: "5.6" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.6" | ||
| - MYSQL_VER: "5.6" | ||
| - <<: *main | ||
| env: | ||
| - PY_VER: "3.5" | ||
| - MYSQL_VER: "5.6" | ||
| - stage: Coverage | ||
| os: linux | ||
| language: shell | ||
| script: | ||
| - sudo pip install python-coveralls | ||
| - coveralls | ||
| >>>>>>> bff58baac8da58b43be95ba1c58174cb7721411f | ||
You are viewing a condensed version of this merge commit. You can view the full changes here.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be removed... Travis tests will no longer run on this PR until this is addressed.