-
Notifications
You must be signed in to change notification settings - Fork 9
Standard integration tests, PEP8, docker adjustments #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
dcb062a
WIP PEP8
CBroz1 2f842b2
WIP Draft integration tests
CBroz1 bbfe140
WIP standard pytests. missing element-event. passed CLI, need docker …
CBroz1 c143548
WIP docker edits
CBroz1 7d4f879
minor docker changes
CBroz1 0cfdcf3
Revised docker from @iamamutt
CBroz1 90d0d74
Apply suggestions from code review
CBroz1 c77ac0c
WIP. Replace with dj image. TLS config statement
CBroz1 39d252d
Docker success *if detatched*
CBroz1 6a66ec4
Add contact info to Code of Conduct
CBroz1 a875dca
Remove order constraints in test_pipeline_generation
CBroz1 a777f34
WIP: Apply suggestions 1
CBroz1 c34d325
WIP: Apply suggestions 2
CBroz1 7e41a3a
WIP: Apply suggestions 3. All except Docker
CBroz1 217a84d
Revert dockerfile arg; adjust 05-explore
CBroz1 d7165ac
Apply suggestions from code review
CBroz1 8435df2
WIP. See details. Jupysync, verbose context, abc.Seq, etc.
CBroz1 b1e45a2
WIP: verbosity if to oneliner
CBroz1 68b04ed
Version bump
CBroz1 6fc72ee
Notebook fix black'd issues. Docker compose vol map
CBroz1 fd89eba
Revise notebook 02 - formatting issues
CBroz1 50fcc20
Revert nb 05
CBroz1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| # Changelog | ||
|
|
||
| Observes [Semantic Versioning](https://semver.org/spec/v2.0.0.html) standard and | ||
| [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) convention. | ||
|
|
||
| ## [0.1.0] - 2021-05-04 | ||
| ### Added | ||
| + Added version | ||
CBroz1 marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,133 @@ | ||
|
|
||
| # Contributor Covenant Code of Conduct | ||
|
|
||
| ## Our Pledge | ||
|
|
||
| We as members, contributors, and leaders pledge to make participation in our | ||
| community a harassment-free experience for everyone, regardless of age, body | ||
| size, visible or invisible disability, ethnicity, sex characteristics, gender | ||
| identity and expression, level of experience, education, socio-economic status, | ||
| nationality, personal appearance, race, caste, color, religion, or sexual | ||
| identity and orientation. | ||
|
|
||
| We pledge to act and interact in ways that contribute to an open, welcoming, | ||
| diverse, inclusive, and healthy community. | ||
|
|
||
| ## Our Standards | ||
|
|
||
| Examples of behavior that contributes to a positive environment for our | ||
| community include: | ||
|
|
||
| * Demonstrating empathy and kindness toward other people | ||
| * Being respectful of differing opinions, viewpoints, and experiences | ||
| * Giving and gracefully accepting constructive feedback | ||
| * Accepting responsibility and apologizing to those affected by our mistakes, | ||
| and learning from the experience | ||
| * Focusing on what is best not just for us as individuals, but for the overall | ||
| community | ||
|
|
||
| Examples of unacceptable behavior include: | ||
|
|
||
| * The use of sexualized language or imagery, and sexual attention or advances of | ||
| any kind | ||
| * Trolling, insulting or derogatory comments, and personal or political attacks | ||
| * Public or private harassment | ||
| * Publishing others' private information, such as a physical or email address, | ||
| without their explicit permission | ||
| * Other conduct which could reasonably be considered inappropriate in a | ||
| professional setting | ||
|
|
||
| ## Enforcement Responsibilities | ||
|
|
||
| Community leaders are responsible for clarifying and enforcing our standards of | ||
| acceptable behavior and will take appropriate and fair corrective action in | ||
| response to any behavior that they deem inappropriate, threatening, offensive, | ||
| or harmful. | ||
|
|
||
| Community leaders have the right and responsibility to remove, edit, or reject | ||
| comments, commits, code, wiki edits, issues, and other contributions that are | ||
| not aligned to this Code of Conduct, and will communicate reasons for moderation | ||
| decisions when appropriate. | ||
|
|
||
| ## Scope | ||
|
|
||
| This Code of Conduct applies within all community spaces, and also applies when | ||
| an individual is officially representing the community in public spaces. | ||
| Examples of representing our community include using an official e-mail address, | ||
| posting via an official social media account, or acting as an appointed | ||
| representative at an online or offline event. | ||
|
|
||
| ## Enforcement | ||
|
|
||
| Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
| reported to the community leaders responsible for enforcement at | ||
| [[email protected]](mailto:[email protected]). | ||
| All complaints will be reviewed and investigated promptly and fairly. | ||
|
|
||
| All community leaders are obligated to respect the privacy and security of the | ||
| reporter of any incident. | ||
|
|
||
| ## Enforcement Guidelines | ||
|
|
||
| Community leaders will follow these Community Impact Guidelines in determining | ||
| the consequences for any action they deem in violation of this Code of Conduct: | ||
|
|
||
| ### 1. Correction | ||
|
|
||
| **Community Impact**: Use of inappropriate language or other behavior deemed | ||
| unprofessional or unwelcome in the community. | ||
|
|
||
| **Consequence**: A private, written warning from community leaders, providing | ||
| clarity around the nature of the violation and an explanation of why the | ||
| behavior was inappropriate. A public apology may be requested. | ||
|
|
||
| ### 2. Warning | ||
|
|
||
| **Community Impact**: A violation through a single incident or series of | ||
| actions. | ||
|
|
||
| **Consequence**: A warning with consequences for continued behavior. No | ||
| interaction with the people involved, including unsolicited interaction with | ||
| those enforcing the Code of Conduct, for a specified period of time. This | ||
| includes avoiding interactions in community spaces as well as external channels | ||
| like social media. Violating these terms may lead to a temporary or permanent | ||
| ban. | ||
|
|
||
| ### 3. Temporary Ban | ||
|
|
||
| **Community Impact**: A serious violation of community standards, including | ||
| sustained inappropriate behavior. | ||
|
|
||
| **Consequence**: A temporary ban from any sort of interaction or public | ||
| communication with the community for a specified period of time. No public or | ||
| private interaction with the people involved, including unsolicited interaction | ||
| with those enforcing the Code of Conduct, is allowed during this period. | ||
| Violating these terms may lead to a permanent ban. | ||
|
|
||
| ### 4. Permanent Ban | ||
|
|
||
| **Community Impact**: Demonstrating a pattern of violation of community | ||
| standards, including sustained inappropriate behavior, harassment of an | ||
| individual, or aggression toward or disparagement of classes of individuals. | ||
|
|
||
| **Consequence**: A permanent ban from any sort of public interaction within the | ||
| community. | ||
|
|
||
| ## Attribution | ||
|
|
||
| This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
| version 2.1, available at | ||
| [https://www.contributor-covenant.org/version/2/1/code_of_conduct.html][v2.1]. | ||
|
|
||
| Community Impact Guidelines were inspired by | ||
| [Mozilla's code of conduct enforcement ladder][Mozilla CoC]. | ||
|
|
||
| For answers to common questions about this code of conduct, see the FAQ at | ||
| [https://www.contributor-covenant.org/faq][FAQ]. Translations are available at | ||
| [https://www.contributor-covenant.org/translations][translations]. | ||
|
|
||
| [homepage]: https://www.contributor-covenant.org | ||
| [v2.1]: https://www.contributor-covenant.org/version/2/1/code_of_conduct.html | ||
| [Mozilla CoC]: https://github.com/mozilla/diversity | ||
| [FAQ]: https://www.contributor-covenant.org/faq | ||
| [translations]: https://www.contributor-covenant.org/translations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,58 +1,49 @@ | ||
| FROM datajoint/djbase:py3.9-debian-8eb1715 | ||
|
|
||
| ARG GITHUB_USERNAME=datajoint | ||
CBroz1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| USER anaconda:anaconda | ||
|
|
||
| COPY ./workflow-miniscope/docker/apt_requirements.txt /tmp/ | ||
| COPY ./docker/apt_requirements.txt /tmp/ | ||
| RUN /entrypoint.sh echo "Installed dependencies." | ||
|
|
||
| # Install CaImAn | ||
| RUN git clone --branch master https://github.com/kabilar/CaImAn | ||
| WORKDIR /main | ||
| RUN git clone --branch master https://github.com/kabilar/CaImAn | ||
| WORKDIR /main/CaImAn | ||
| RUN conda install -n base -c conda-forge -y mamba | ||
| RUN /bin/bash -c 'mamba env update --n base --file environment.yml' | ||
| RUN /bin/bash -c 'mamba env update --n base --file environment-minimal.yml' | ||
| RUN pip install . | ||
| RUN python caimanmanager.py install --inplace | ||
|
|
||
| WORKDIR /main | ||
|
|
||
| # Option 1 - Install DataJoint's remote fork of the workflow and elements | ||
| # RUN git clone https://github.com/datajoint/workflow-miniscope.git /main/ | ||
|
|
||
| # Option 2 - Install user's remote fork of element and workflow | ||
| # or an unreleased version of the element | ||
| # RUN pip install git+https://github.com/<user>/element-lab.git | ||
| # RUN pip install git+https://github.com/<user>/element-animal.git | ||
| # RUN pip install git+https://github.com/<user>/element-session.git | ||
| # RUN pip install "element-interface@git+https://github.com/<user>/element-interface" | ||
| # RUN pip install git+https://github.com/<user>/element-miniscope.git | ||
| # RUN git clone https://github.com/<user>/workflow-miniscope.git /main/workflow-miniscope | ||
|
|
||
| # Option 3 - Install user's local fork of element and workflow | ||
| RUN mkdir /main/element-lab \ | ||
| /main/element-animal \ | ||
| /main/element-session \ | ||
| /main/element-interface \ | ||
| /main/element-miniscope \ | ||
| /main/workflow-miniscope | ||
|
|
||
| COPY --chown=anaconda:anaconda ./element-lab /main/element-lab | ||
| COPY --chown=anaconda:anaconda ./element-animal /main/element-animal | ||
| COPY --chown=anaconda:anaconda ./element-session /main/element-session | ||
| COPY --chown=anaconda:anaconda ./element-interface /main/element-interface | ||
| COPY --chown=anaconda:anaconda ./element-miniscope /main/element-miniscope | ||
| COPY --chown=anaconda:anaconda ./workflow-miniscope /main/workflow-miniscope | ||
|
|
||
| RUN pip install -e /main/element-lab | ||
| RUN pip install -e /main/element-animal | ||
| RUN pip install -e /main/element-session | ||
| RUN pip install -e /main/element-interface | ||
| RUN pip install -e /main/element-miniscope | ||
| RUN rm -f /main/workflow-miniscope/dj_local_conf.json | ||
|
|
||
| # Install the workflow | ||
| RUN pip install /main/workflow-miniscope | ||
| RUN pip install -r /main/workflow-miniscope/requirements_test.txt | ||
|
|
||
| RUN pip uninstall datajoint | ||
| RUN pip install git+ | ||
| WORKDIR /main/workflow-miniscope | ||
|
|
||
| # 1. Install Elements from github user | ||
| RUN pip install --no-deps "element-interface@git+https://github.com/${GITHUB_USERNAME}/element-interface" | ||
| RUN pip install --no-deps "djarchive-client@git+https://github.com/${GITHUB_USERNAME}/djarchive-client" | ||
| RUN pip install git+https://github.com/${GITHUB_USERNAME}/element-lab.git | ||
| RUN pip install git+https://github.com/${GITHUB_USERNAME}/element-animal.git | ||
| RUN pip install git+https://github.com/${GITHUB_USERNAME}/element-session.git | ||
| RUN pip install git+https://github.com/${GITHUB_USERNAME}/element-event.git | ||
| RUN pip install git+https://github.com/${GITHUB_USERNAME}/element-miniscope.git | ||
| # RUN pip install git+https://github.com/${GITHUB_USERNAME}/workflow-miniscope.git | ||
| # end 1 | ||
|
|
||
| # 2. Install local fork of element and workflow | ||
| # COPY --chown=anaconda:anaconda ../element-lab /main/ | ||
| # COPY --chown=anaconda:anaconda ../element-animal /main/ | ||
| # COPY --chown=anaconda:anaconda ../element-session /main/ | ||
| # COPY --chown=anaconda:anaconda ../element-event /main/ | ||
| # COPY --chown=anaconda:anaconda ../element-interface /main/ | ||
| # COPY --chown=anaconda:anaconda ../element-miniscope /main/ | ||
| COPY --chown=anaconda:anaconda . ./ | ||
| # RUN pip install -e /main/element-lab | ||
| # RUN pip install -e /main/element-animal | ||
| # RUN pip install -e /main/element-session | ||
| # RUN pip install -e /main/element-event | ||
| # RUN pip install -e /main/element-interface | ||
| # RUN pip install -e /main/element-miniscope | ||
| RUN pip install -e . | ||
| # end 2 | ||
|
|
||
| RUN rm -f ./dj_local_conf.json | ||
| RUN pip install -r ./requirements_test.txt | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,4 +5,4 @@ ffmpeg | |
| libsm6 | ||
| libxext6 | ||
| libhdf5-dev | ||
| pkg-config | ||
| pkg-config | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -35,4 +35,4 @@ services: | |
| db: | ||
| condition: service_healthy | ||
| networks: | ||
| main: | ||
| main: | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.