Test nodelete rebased #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With -Werror with GCC 9: ``` error: catching polymorphic type 'struct calf_utils::file_exception' by value [-Werror=catch-value=] ```
LLVM's LLD handles the -retain-symbols-file option (used by -export-symbols-regex in libtool) differently from GNU ld, causing undefined references during link. This commit removes the -export-symbols-regex option from libcalf_la_LDFLAGS since by default libtool exports all symbols anyway, so it should not be necessary. Fixes #156. Signed-off-by: Violet Purcell <[email protected]>
std::bind2nd was deprecated in C++11 and removed in C++17. Remove usage of it and replace with std::bind. Signed-off-by: Violet Purcell <[email protected]>
- first check if ~/.calfrc exists, if it does use it - otherwise attempt to create $XDG_CONFIG_HOME/calf/ if it does not exist - if the folder now exists use as path $XDG_CONFIG_HOME/calf/calfrc, otherwise fall back to ~/.calfrc
Fixes loading of lv2 plugin and its gui.
Fixup from c41d8c0 . That commit tried to pass the static variable `_synths` to a function (`std::max`), but there is no definition of `_synths`, so it cannot be passed to a function. However, a simple ternary expression counts as `constexpr`, not requiring a definition of `_synths`.
From the MS docs about _alloca: ``` _alloca allocates size bytes from the program stack. The allocated space is automatically freed when the calling function exits (not when the allocation merely passes out of scope). ``` So, using _alloca in a loop is a very bad idea, and this PR fixes this.
Hello. Please accept the translation into the pt_BR language. The file with the most recent translation can also be found on my GitHub. I appreciate you developing and keeping the "Calf Plugin Pack for JACK" program up to date. marcelocripe (Original text in Brazilian Portuguese language) - - - - - Olá. Por favor, aceite a tradução para o idioma pt_BR. O arquivo com a tradução mais recente também poderá ser encontrado no meu GitHub. Eu agradeço por vocês desenvolverem e manterem o programa "Calf Plugin Pack for JACK" atualizado. marcelocripe (Texto original em idioma Português do Brasil)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @david0 , can you please accept my PR against your PR? I only merged the newest master in, in order to solve merge conflicts.