Skip to content

Conversation

@joefiorini
Copy link
Contributor

Fixes #6

@dbrans
Copy link
Owner

dbrans commented Jun 15, 2016

@aokolish @joefiorini
global isFinite and Number.isFinite are slightly different.

Would you mind writing a function numberIsFinite that uses Number.isFinite if it's there and otherwise uses the global isFinite but special-cases anyString => false and null => false?

@joefiorini
Copy link
Contributor Author

@dbrans how about we just use the polyfill suggested on that page? https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isFinite#Polyfill

@dbrans
Copy link
Owner

dbrans commented Jun 15, 2016

@joefiorini perfect. Do you or @aokolish want to update this PR?

@joefiorini
Copy link
Contributor Author

@dbrans i'll get to it tomorrow

@joefiorini
Copy link
Contributor Author

@dbrans turns out lodash includes this polyfill, so I went ahead and used that instead (using a package that includes just that function for now).

@dbrans dbrans merged commit 32e0857 into dbrans:master Jun 21, 2016
@dbrans dbrans deleted the fix-ie-11 branch June 21, 2016 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants