Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
I think this fixes IE11 compatibility
  • Loading branch information
aokolish authored and joefiorini committed Jun 21, 2016
commit bf72acd7aa190f8c19488aa3b9edceb4b6599404
3 changes: 2 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
"react": "^0.14.0"
},
"dependencies": {
"invariant": "^2.1.2"
"invariant": "^2.1.2",
"lodash.isfinite": "^3.3.1"
}
}
3 changes: 2 additions & 1 deletion src/abstract-number-format-input/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import escapeRegExp from './util/escapeRegExp';
import indexOfLastDigit from './util/indexOfLastDigit';
import invariant from 'invariant';
import nextPosition from './nextPosition';
import isFinite from 'lodash.isfinite';

function indexOfDigit(str, start, direction) {
let pos = start;
Expand Down Expand Up @@ -51,7 +52,7 @@ export default function createAbstractNumberFormatInput(numberFormat) {
function format(number) {
if (number === null || number === undefined) return '';
if (typeof number === 'string') return format(parse(number));
invariant(Number.isFinite(number), `Illegal number value: ${JSON.stringify(number)}`);
invariant(isFinite(number), `Illegal number value: ${JSON.stringify(number)}`);
return addTrailingZeros(numberFormat.format(number));
}

Expand Down
3 changes: 2 additions & 1 deletion src/abstract-number-format-input/util/parseNumber.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import escapeRegExp from './escapeRegExp';
import invariant from 'invariant';
import isFinite from 'lodash.isfinite';

function assertZeroOrOneDecimalChar(str, decimalChar) {
if (!decimalChar) return;
Expand All @@ -20,7 +21,7 @@ export default function parseNumber(formattedNumber, decimalChar) {
invariant(numberStr.lastIndexOf('-') <= 0, `Misplaced minus sign in '${numberStr}'`);

const number = parseFloat(numberStr);
invariant(Number.isFinite(number), `parseFloat was unable to parse '${numberStr}'`);
invariant(isFinite(number), `parseFloat was unable to parse '${numberStr}'`);

return number;
}