Skip to content
This repository was archived by the owner on Sep 2, 2025. It is now read-only.

Try dbt-core#7368 #774

Closed
jtcohen6 wants to merge 4 commits into from
Closed

Try dbt-core#7368 #774

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ec02ab0
Try dbt-labs/dbt-core#7368
jtcohen6 Jun 15, 2023
1a50adf
Update agate pin
jtcohen6 Jun 15, 2023
583505e
Rm agate as explicit dep
jtcohen6 Jun 16, 2023
45c5757
Account for change in dbt-labs/dbt-core#7857
jtcohen6 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update agate pin
  • Loading branch information
@jtcohen6
jtcohen6 committed Jun 15, 2023
commit 1a50adff9c0d27d85af84c4e5be89b809d77d81c
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def _dbt_core_version(plugin_version: str) -> str:
"google-cloud-bigquery~=3.0",
"google-cloud-storage~=2.4",
"google-cloud-dataproc~=5.0",
"agate~=1.6.3",
"agate~=1.7.0",
Copy link
Contributor Author

@jtcohen6 jtcohen6 Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why agate is an explicit dependency here, rather than just using the transitive dependency from dbt-core?

Copy link
Contributor Author

@jtcohen6 jtcohen6 Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@colin-rogers-dbt Looks like you added this back in #458 (d27cf24)

Copy link
Contributor

@colin-rogers-dbt colin-rogers-dbt Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't remember why, if it's causing issues we can certainly remove it

Copy link
Contributor

@mikealfare mikealfare Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep agate if we're using it directly, but without a pin.

We ran into an issue a few months ago where a requirement was dropped from dbt-core that was used directly in an adapter. To avoid version conflicts, we did not explicitly list it as a requirement in the adapter; hence the adapter broke when we removed it from dbt-core. This is likely a rare occurrence, but I think this is the right compromise with the least downsides. I did that here in dbt-redshift:

https://github.com/dbt-labs/dbt-redshift/blob/36bed56310645669a9bf20b882e6aed51bf1b98a/setup.py#L89-L90

Copy link
Contributor Author

@jtcohen6 jtcohen6 Jun 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mikealfare Heard! I removed it in #778; shall I open a new PR to add it back (without a pin)?

],
zip_safe=False,
classifiers=[
Expand Down