Skip to content

Adding Metric Helper Functions #5607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emmyoop merged 6 commits into from
Aug 8, 2022
Merged

Adding Metric Helper Functions #5607

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1006279
Adding helper functions
callum-mcdata Aug 3, 2022
087d3ec
adding bad test
callum-mcdata Aug 3, 2022
24eff73
use ResolvedMetricReference
ChenyuLInx Aug 3, 2022
2910f7b
adding pytest
callum-mcdata Aug 4, 2022
9ef38db
adding changie updates
callum-mcdata Aug 4, 2022
13e8941
adding pre-commit changes
callum-mcdata Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use ResolvedMetricReference
  • Loading branch information
@ChenyuLInx
ChenyuLInx committed Aug 3, 2022
commit 24eff73d443a08029fcd3ff86534536a84c2ff37
22 changes: 9 additions & 13 deletions tests/functional/metrics/test_metric_helper_functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
import pytest

from dbt.tests.util import run_dbt, get_manifest
from dbt.exceptions import ParsingException

from tests.functional.metrics.fixture_metrics import mock_purchase_data_csv

from dbt.contracts.graph.metrics import ResolvedMetricReference

metrics__yml = """
version: 2
Expand Down Expand Up @@ -63,6 +60,7 @@
select 1 as id, 'Callum' as first_name, 'McCann' as last_name, 'emerald' as favorite_color, true as loves_dbt, 0 as tenure, current_timestamp as created_at
"""


class TestMetricHelperFunctions:
@pytest.fixture(scope="class")
def models(self):
Expand All @@ -77,18 +75,16 @@ def test_expression_metric(
):

# initial parse
results = run_dbt(["compile"])
run_dbt(["compile"])

# make sure all the metrics are in the manifest
manifest = get_manifest(project.project_root)
testing_metric = manifest.metrics["metric.test.average_tenure_plus_one"]
full_metric_dependency = testing_metric.full_metric_dependency()
parsed_metric = manifest.metrics["metric.test.average_tenure_plus_one"]
testing_metric = ResolvedMetricReference(parsed_metric, manifest, None)
full_metric_dependency = set(testing_metric.full_metric_dependency())

expected_full_metric_dependency = [
"average_tenure_plus_one",
"average_tenure",
"collective_tenure",
"number_of_people"
]
expected_full_metric_dependency = set(
["average_tenure_plus_one", "average_tenure", "collective_tenure", "number_of_people"]
)

assert full_metric_dependency == expected_full_metric_dependency