Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
adding pytest
  • Loading branch information
callum-mcdata committed Aug 4, 2022
commit 2910f7bc0390c38dadca11bb9a44d52bd129cdfe
2 changes: 1 addition & 1 deletion core/dbt/contracts/graph/metrics.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def parent_metrics_names(cls, metric_node, manifest):
@classmethod
def reverse_dag_parsing(cls, metric_node, manifest, metric_depth_count):
if metric_node.type == "expression":
yield {metric_node.unique_id:metric_depth_count}
yield {metric_node.name:metric_depth_count}
metric_depth_count = metric_depth_count+1

for parent_unique_id in metric_node.depends_on.nodes:
Expand Down
22 changes: 20 additions & 2 deletions tests/functional/metrics/test_metric_helper_functions.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,28 @@ def test_expression_metric(
manifest = get_manifest(project.project_root)
parsed_metric = manifest.metrics["metric.test.average_tenure_plus_one"]
testing_metric = ResolvedMetricReference(parsed_metric, manifest, None)


full_metric_dependency = set(testing_metric.full_metric_dependency())

expected_full_metric_dependency = set(
["average_tenure_plus_one", "average_tenure", "collective_tenure", "number_of_people"]
)

assert full_metric_dependency == expected_full_metric_dependency

base_metric_dependency = set(testing_metric.base_metric_dependency())
expected_base_metric_dependency = set(
["collective_tenure", "number_of_people"]
)
assert base_metric_dependency == expected_base_metric_dependency

derived_metric_dependency = set(testing_metric.derived_metric_dependency())
expected_derived_metric_dependency = set(
["average_tenure_plus_one", "average_tenure"]
)
assert derived_metric_dependency == expected_derived_metric_dependency

derived_metric_dependency_depth = list(testing_metric.derived_metric_dependency_depth())
expected_derived_metric_dependency_depth = list(
[{"average_tenure_plus_one":1}, {"average_tenure":2}]
)
assert derived_metric_dependency_depth == expected_derived_metric_dependency_depth