Add back depends_on for seeds - only macros, never nodes

[jtcohen6]

resolves #6806

Description

• Seeds can have pre/post hooks that call macros, and we need to track these in the seed's depends_on
• If those macros try to take a dependency on another node, this is an unsupported anti-pattern — raise an explicit error

I'm not thrilled with this approach, which requires a bit of mucking with magic methods, but it does keep the changes fairly self-contained.

If we do move forward with this approach, we'll need to:

• backport to 1.4.latest
• (!) update the v8 manifest schema definition

Checklist

• I have read the contributing guide and understand what's expected of me
• I have signed the CLA
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
• I have run changie new to create a changelog entry

[gshank]

I think the approach is fine. We do already use getattr in a couple of other places and it's the only real place to put a user friendly error message if somebody tries to use the missing and prohibited methods.

[joeinnyc]

+1 on this please

[gshank]

It occurred to me that instead of using setattr, we could provide "property" methods for ref/sources/metrics that throws an error. Either way is fine with me.

[jtcohen6]

It occurred to me that instead of using setattr, we could provide "property" methods for ref/sources/metrics that throws an error.

@gshank I like that much better! Significantly less magic.

[sfc-gh-pkommini]

Hi Team, Which release would the changes in this PR make it into?

[jtcohen6]

@sfc-gh-pkommini This has been backported for inclusion in the next v1.4.x patch release. There are a few more in-progress bug fixes we're hoping to include; at this point, we'll probably put out a release candidate next week.

[smitsrr]

Second - looking for an update as we're blocked from upgrading until this bug is included in a release.

[jtcohen6]

@sfc-gh-pkommini @smitsrr This fix has been included in a release candidate of v1.4.2 (next patch). Could you try it out and confirm that it fixes the issue for you?

pip install dbt-core==1.4.2rc1 dbt-<youradapter>