[Backport 1.4.latest] Add back depends_on for seeds - only macros, never nodes#6920
Merged
jtcohen6 merged 3 commits into1.4.latestfrom Feb 9, 2023
Merged
[Backport 1.4.latest] Add back depends_on for seeds - only macros, never nodes#6920jtcohen6 merged 3 commits into1.4.latestfrom
depends_on for seeds - only macros, never nodes#6920jtcohen6 merged 3 commits into1.4.latestfrom
Conversation
* Extend functional tests for seeds w hooks * Add MacroDependsOn to seeds, raise exception for other deps * Add changelog entry * Fix unit tests * Update upgrade_seed_content * Cleanup * Regen manifest v8 schema. Fix tests * Be less magical * PR feedback (cherry picked from commit 298bf8a)
jtcohen6
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 298bf8a from #6851.