Skip to content

Conversation

@iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Feb 3, 2023

resolves #
https://media.tenor.com/5WTzTOGLLyEAAAAC/no-ticket-indiana-jones.gif

Description

Fixes issue where FailedToConnectError errors stop test from being completed due to not using pytest.raises

Checklist

@cla-bot cla-bot bot added the cla:yes label Feb 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 3, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa added the Skip Changelog Skips GHA to check for changelog file label Feb 3, 2023
@iknox-fa iknox-fa marked this pull request as ready for review February 3, 2023 19:22
@iknox-fa iknox-fa requested a review from a team as a code owner February 3, 2023 19:22
@iknox-fa iknox-fa requested review from MichelleArk, VersusFacit and gshank and removed request for VersusFacit and gshank February 3, 2023 19:22
@@ -1,31 +1,29 @@
import pytest
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorted imports aren't material to test changes, just improving the readability a bit.

Copy link
Contributor

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@iknox-fa iknox-fa merged commit 05e53d4 into feature/click-cli Feb 6, 2023
@iknox-fa iknox-fa deleted the iknox/fix-TestProfileEnvVars-test_profile_env_vars branch February 6, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes Skip Changelog Skips GHA to check for changelog file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants