Skip to content

Reorganize, annotate, and revise dependency pins #7368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtcohen6 merged 6 commits into from
Jun 21, 2023
Merged

Reorganize, annotate, and revise dependency pins #7368

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5020334
Reorganize + annotate dependencies
jtcohen6 Apr 17, 2023
c4e762d
Loosen pins on other dbt-labs packages
jtcohen6 Apr 17, 2023
35888c9
Minor pins, no patch pins
jtcohen6 Apr 17, 2023
fd6c57d
Rm support for py37
jtcohen6 Jun 7, 2023
03c4af9
Fix protobuf pin
jtcohen6 Jun 15, 2023
48ea216
Bump networkx upper bound #6551
jtcohen6 Jun 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Minor pins, no patch pins
  • Loading branch information
@jtcohen6
jtcohen6 committed Jun 20, 2023
commit 35888c915fe3f91e35ab57abee182b2cf42afbb2
6 changes: 3 additions & 3 deletions core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@
# ----
# dbt-core uses these packages deeply, throughout the codebase, and there have been breaking changes in past patch releases (even though these are major-version-one).
# Pin to the patch or minor version, and bump in each new minor version of dbt-core.
"agate>=1.6,<1.7.1",
"Jinja2==3.1.2",
"mashumaro[msgpack]==3.6",
"agate~=1.7.0",
"Jinja2~=3.1.2",
"mashumaro[msgpack]~=3.7.0",
Copy link
Member

@emmyoop emmyoop Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gshank I saw you comment on #7847 that we're waiting on the next release to upgrade. Should this stay at minor version 6?

Copy link
Contributor Author

@jtcohen6 jtcohen6 Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emmyoop Good catch!

@gshank Is there anything that you're concerned about in the upgrade to 3.7? Or are there specific things we're looking forward to in the next release, which should be coming soonish - Fatal1ty/mashumaro#104 (comment)?

Copy link
Contributor

@gshank gshank Jun 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading to 3.7 is fine. I'm waiting for the next release to come out, so thought we could skip it. But no reason not to, I guess.

# ----
# Legacy: This package has not been updated since 2019, and it is unused in dbt's logging system (since v1.0)
# The dependency here will be removed along with the removal of 'legacy logging', in a future release of dbt-core
Expand Down