-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Semantic model configs - enable/disable + groups #8502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #8502 +/- ##
==========================================
+ Coverage 86.34% 86.36% +0.02%
==========================================
Files 174 174
Lines 25541 25579 +38
==========================================
+ Hits 22054 22092 +38
Misses 3487 3487
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
1cd16eb to
7cb452d
Compare
QMalcolm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this work! It's looking great 🙂 One thing that caught my attention is that we're handling disabled semantic models during resolution differently than we handle resolution of all other nodes. It confused me for awhile, and then I recognized that it was necessary due to our indirect referencing from the measure being the intermediary for the lookup (making the DisabledLookup not fit this use case).
It feels weird to me. Seems like we might need a refactoring here sometime, but I think that's out of scope for this.
0eb8560 to
34e35ba
Compare
9bbc643 to
05431bc
Compare
|
Opened a new issue in dbt-labs/docs.getdbt.com: dbt-labs/docs.getdbt.com#3997 |
resolves #7968
docs
Problem
Semantic models cannot be enabled/disabled and also cannot belong to groups.
Solution
Enable configs to allow semantic models to be disabled and be in groups.
When a semantic model is disabled but the defined metric for the measure is not, it throws a ParsingError.
Checklist