Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cleanup
  • Loading branch information
emmyoop committed Aug 31, 2023
commit 19ad2cddaaebfd495fc70a19c30ce52ba335a04c
6 changes: 0 additions & 6 deletions core/dbt/contracts/graph/nodes.py
Original file line number Diff line number Diff line change
Expand Up @@ -1639,12 +1639,6 @@ def depends_on_nodes(self):
def depends_on_macros(self):
return self.depends_on.macros

# def same_config(self, old: "SemanticModel") -> bool:
# return self.config.same_contents(
# self.unrendered_config,
# old.unrendered_config,
# )

def checked_agg_time_dimension_for_measure(
self, measure_reference: MeasureReference
) -> TimeDimensionReference:
Expand Down
6 changes: 3 additions & 3 deletions core/dbt/parser/schema_yaml_readers.py
Original file line number Diff line number Diff line change
Expand Up @@ -533,13 +533,13 @@ def _generate_semantic_model_config(

# configs with precendence set
precedence_configs = dict()
# first apply metric configs
# first apply semantic model configs
precedence_configs.update(target.config)

config = generator.calculate_node_config(
config_call_dict={},
fqn=fqn,
resource_type=NodeType.Metric,
resource_type=NodeType.SemanticModel,
project_name=package_name,
base=False,
patch_config_dict=precedence_configs,
Expand Down Expand Up @@ -600,7 +600,7 @@ def parse_semantic_model(self, unparsed: UnparsedSemanticModel):

if parsed.model is not None:
model_ref = "{{ " + parsed.model + " }}"
# This sets the "refs" in the SemanticModel from the MetricRefResolver in context/providers.py
# This sets the "refs" in the SemanticModel from the SemanticModelRefResolver in context/providers.py
get_rendered(model_ref, ctx, parsed)

# No ability to disable a semantic model at this time
Expand Down