Skip to content

Switch from checked_agg_time_dimension to checked_agg_time_dimension_for_measure #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 10 commits into from
Jul 12, 2023
Merged

Switch from checked_agg_time_dimension to checked_agg_time_dimension_for_measure #113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f49bacb
Add `checked_agg_time_dimension_for_measure` to `SemanticModel` proto…
QMalcolm Jul 11, 2023
ece836a
Update `MeasuresNonAdditiveDimensionRule` validation rule to use `che…
QMalcolm Jul 11, 2023
edf1417
Update `AggregationTimeDimensionRule` to use `checked_agg_time_dimens…
QMalcolm Jul 11, 2023
b7a0a0b
Remove `SemanticModelTimeDimensionWarningsRule` validation rule
QMalcolm Jul 11, 2023
e1007df
Remove `SetMeasureAggregationTimeDimensionRule` transformation rule
QMalcolm Jul 11, 2023
c087688
Drop `checked_agg_time_dimension` from `Measure` protocol
QMalcolm Jul 11, 2023
87b9a1f
Remove `checked_agg_time_dimension` from `PydanticMeasure` implementa…
QMalcolm Jul 11, 2023
b904571
Update `test_unset_aggregation_time_dimension` to work with `agg_time…
QMalcolm Jul 11, 2023
88de482
Changie doc for switch to checked_agg_time_dimension_for_measure
QMalcolm Jul 11, 2023
315c4e2
Update `checked_agg_time_dimension_for_measure` to only require a `Me…
QMalcolm Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove SemanticModelTimeDimensionWarningsRule validation rule 
It essentialy the same as the `AggregationTimeDimensionRule`, but only
giving a warning.
  • Loading branch information
@QMalcolm
QMalcolm committed Jul 11, 2023
commit b7a0a0b5c84fcfdd0c6f9d0ee04bad27e3b21eed
2 changes: 0 additions & 2 deletions dbt_semantic_interfaces/validations/semantic_manifest_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
from dbt_semantic_interfaces.validations.reserved_keywords import ReservedKeywordsRule
from dbt_semantic_interfaces.validations.semantic_models import (
SemanticModelDefaultsRule,
SemanticModelTimeDimensionWarningsRule,
SemanticModelValidityWindowRule,
)
from dbt_semantic_interfaces.validations.unique_valid_name import UniqueAndValidNameRule
Expand Down Expand Up @@ -62,7 +61,6 @@ class SemanticManifestValidator(Generic[SemanticManifestT]):
DerivedMetricRule[SemanticManifestT](),
CountAggregationExprRule[SemanticManifestT](),
SemanticModelMeasuresUniqueRule[SemanticManifestT](),
SemanticModelTimeDimensionWarningsRule[SemanticManifestT](),
SemanticModelValidityWindowRule[SemanticManifestT](),
DimensionConsistencyRule[SemanticManifestT](),
ElementConsistencyRule[SemanticManifestT](),
Expand Down
37 changes: 0 additions & 37 deletions dbt_semantic_interfaces/validations/semantic_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,43 +17,6 @@
logger = logging.getLogger(__name__)


class SemanticModelTimeDimensionWarningsRule(
SemanticManifestValidationRule[SemanticManifestT], Generic[SemanticManifestT]
):
"""Checks time dimensions in semantic models."""

@staticmethod
@validate_safely(whats_being_done="running model validation ensuring time dimensions are defined properly")
def validate_manifest(semantic_manifest: SemanticManifestT) -> Sequence[ValidationIssue]: # noqa: D
issues: List[ValidationIssue] = []

for semantic_model in semantic_manifest.semantic_models:
issues.extend(
SemanticModelTimeDimensionWarningsRule._validate_semantic_model(semantic_model=semantic_model)
)
return issues

@staticmethod
@validate_safely(whats_being_done="checking validity of the semantic model's time dimensions")
def _validate_semantic_model(semantic_model: SemanticModel) -> List[ValidationIssue]:
issues: List[ValidationIssue] = []

for measure in semantic_model.measures:
if measure.agg_time_dimension is None:
issues.append(
ValidationError(
context=SemanticModelContext(
file_context=FileContext.from_metadata(metadata=semantic_model.metadata),
semantic_model=SemanticModelReference(semantic_model_name=semantic_model.name),
),
message=f"Aggregation time dimension not specified for measure named '{measure.name}' in the "
f"semantic model named '{semantic_model.name}'. Please add one",
)
)

return issues


class SemanticModelValidityWindowRule(SemanticManifestValidationRule[SemanticManifestT], Generic[SemanticManifestT]):
"""Checks validity windows in semantic models to ensure they comply with runtime requirements."""

Expand Down