Skip to content

Switch from checked_agg_time_dimension to checked_agg_time_dimension_for_measure #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QMalcolm merged 10 commits into from
Jul 12, 2023
Merged

Switch from checked_agg_time_dimension to checked_agg_time_dimension_for_measure #113

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f49bacb
Add `checked_agg_time_dimension_for_measure` to `SemanticModel` proto…
QMalcolm Jul 11, 2023
ece836a
Update `MeasuresNonAdditiveDimensionRule` validation rule to use `che…
QMalcolm Jul 11, 2023
edf1417
Update `AggregationTimeDimensionRule` to use `checked_agg_time_dimens…
QMalcolm Jul 11, 2023
b7a0a0b
Remove `SemanticModelTimeDimensionWarningsRule` validation rule
QMalcolm Jul 11, 2023
e1007df
Remove `SetMeasureAggregationTimeDimensionRule` transformation rule
QMalcolm Jul 11, 2023
c087688
Drop `checked_agg_time_dimension` from `Measure` protocol
QMalcolm Jul 11, 2023
87b9a1f
Remove `checked_agg_time_dimension` from `PydanticMeasure` implementa…
QMalcolm Jul 11, 2023
b904571
Update `test_unset_aggregation_time_dimension` to work with `agg_time…
QMalcolm Jul 11, 2023
88de482
Changie doc for switch to checked_agg_time_dimension_for_measure
QMalcolm Jul 11, 2023
315c4e2
Update `checked_agg_time_dimension_for_measure` to only require a `Me…
QMalcolm Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update MeasuresNonAdditiveDimensionRule validation rule to use `che… 
…cked_agg_time_dimension_for_measure`
  • Loading branch information
@QMalcolm
QMalcolm committed Jul 11, 2023
commit ece836a441ae93205f4bbeb6239e7e6eec7bf5ed
9 changes: 3 additions & 6 deletions dbt_semantic_interfaces/validations/measures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,12 +232,9 @@ def validate_manifest(semantic_manifest: SemanticManifestT) -> Sequence[Validati
non_additive_dimension = measure.non_additive_dimension
if non_additive_dimension is None:
continue
agg_time_dimension_reference = semantic_model.checked_agg_time_dimension_for_measure(measure)
agg_time_dimension = next(
(
dim
for dim in semantic_model.dimensions
if measure.checked_agg_time_dimension.element_name == dim.name
),
(dim for dim in semantic_model.dimensions if agg_time_dimension_reference.element_name == dim.name),
None,
)
if agg_time_dimension is None:
Expand All @@ -253,7 +250,7 @@ def validate_manifest(semantic_manifest: SemanticManifestT) -> Sequence[Validati
),
message=(
f"Measure '{measure.name}' has a agg_time_dimension of "
f"{measure.checked_agg_time_dimension.element_name} "
f"{agg_time_dimension_reference.element_name} "
f"that is not defined as a dimension in semantic model '{semantic_model.name}'."
),
)
Expand Down