[WIP] - Upgrade elasticsearch support to 6.2 #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimbinatus
requested changes
Mar 27, 2018
| }, | ||
| "author": "Ken Perkins <[email protected]>", | ||
| "license": "MIT", | ||
| "dependencies": { |
Member
There was a problem hiding this comment.
Version bump needed on line 3. As I think this is a release that will break previous versions, this release would bump to 2.0.0. See https://semver.org/#summary for more info.
Contributor
Author
There was a problem hiding this comment.
So we have another PR where the version goes to 1.1.0, and this to 2.0.0, and then we have that mongo bump. What makes sense to version for each of these?
Member
There was a problem hiding this comment.
After discussion, decided to go to 2.0.0 for both ES and MongoDB updates (breaking changes, but can go under the same version).
nimbinatus
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the necessary changes to support the latest version of Elasticsearch. It required updating the npm package as well as updating how searches are performed.
fixes #127
fixes #123