[WIP] - mongodb upgrade 20180316 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nimbinatus
requested changes
Mar 27, 2018
package.json
Outdated
| "dependencies": { | ||
| "async": "2.0.0-rc.2", | ||
| "cheerio": "^0.19.0", | ||
| "elasticsearch": "^9.0.2", |
Member
There was a problem hiding this comment.
Bump version on line 3. Recommend 2.0.0 (or 3.0.0, really, if we merge #129 first) as this is a backwards-incompatible change. See https://semver.org/#summary for more info.
Member
There was a problem hiding this comment.
Decided to keep at 2.0.0 from the es update. See #129 for discussion.
nimbinatus
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated mongodb library to the latest in order to support 3.6.
fixes #131