Feat: Rollback support added for devtron charts. #1405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pghildiyal
reviewed
Mar 25, 2022
| func (impl AppStoreDeploymentFullModeServiceImpl) UpdateValuesYaml(installAppVersionRequest *appStoreBean.InstallAppVersionDTO) (*appStoreBean.InstallAppVersionDTO, error) { | ||
| acdAppName := fmt.Sprintf("%s-%s", installAppVersionRequest.AppName, installAppVersionRequest.EnvironmentName) | ||
| gitOpsRepoName := installAppVersionRequest.GitOpsRepoName | ||
| if len(gitOpsRepoName) == 0 { |
Contributor
There was a problem hiding this comment.
i think we are using similar code to fetch gitops repo at other places also.. should extact it out as function
pghildiyal
reviewed
Mar 25, 2022
| } | ||
| gitOpsConfigBitbucket, err := impl.gitOpsRepository.GetGitOpsConfigByProvider(util.BITBUCKET_PROVIDER) | ||
| if err != nil { | ||
| if err == pg.ErrNoRows { |
Contributor
There was a problem hiding this comment.
this code should be inside GetGitOpsConfigByProvider
Contributor
Author
There was a problem hiding this comment.
GetGitOpsConfigByProvider has only its global config services
pghildiyal
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User not able to go back to previous values as we don't have build history ye. added API support where user can deploy re-deploy to a specific older configuration with same chart version or other chart version.
User now able to rollback to specific older version of deployment history.
Fixes # (issue) :1298
Type of change
How Has This Been Tested?
Checklist: