Skip to content

Feat: Rollback support added for devtron charts. #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pghildiyal merged 9 commits into from
Mar 28, 2022
Merged

Feat: Rollback support added for devtron charts. #1405

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04b2302
rollback support added for devtron charts
vikramdevtron Mar 25, 2022
afdf054
fixes around rollback
vikramdevtron Mar 25, 2022
e28ace3
values fixed in rollback
vikramdevtron Mar 25, 2022
275ce3d
rollback request failure handling
vikramdevtron Mar 25, 2022
8d1a3fe
values fix on rollback
vikramdevtron Mar 25, 2022
6188bcb
invalid relations btw ids in request validate
vikramdevtron Mar 25, 2022
0ba0a2d
review change - gitops repo name fetch acd logic by common function
vikramdevtron Mar 25, 2022
416a9b4
main merged into this branch
vikramdevtron Mar 26, 2022
5232eb0
api erro codes modfication for rollback
vikramdevtron Mar 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
api erro codes modfication for rollback
  • Loading branch information
@vikramdevtron
vikramdevtron committed Mar 26, 2022
commit 5232eb0c78de01b53f574bc170bc58455dc23231
12 changes: 7 additions & 5 deletions pkg/appStore/deployment/tool/gitops/AppStoreDeploymentArgoCdService.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,23 +153,25 @@ func (impl AppStoreDeploymentArgoCdServiceImpl) RollbackRelease(ctx context.Cont
versionHistory, err := impl.installedAppRepositoryHistory.GetInstalledAppVersionHistory(int(installedAppVersionHistoryId))
if err != nil {
impl.Logger.Errorw("error", "err", err)
return installedApp, false, nil
err = &util.ApiError{Code: "404", HttpStatusCode: 404, UserMessage: fmt.Sprintf("No deployment history version found for id: %d", installedAppVersionHistoryId), InternalMessage: err.Error()}
return installedApp, false, err
}
installedAppVersion, err := impl.installedAppRepository.GetInstalledAppVersionAny(versionHistory.InstalledAppVersionId)
if err != nil {
impl.Logger.Errorw("error", "err", err)
return installedApp, false, nil
err = &util.ApiError{Code: "404", HttpStatusCode: 404, UserMessage: fmt.Sprintf("No installed app version found for id: %d", versionHistory.InstalledAppVersionId), InternalMessage: err.Error()}
return installedApp, false, err
}
activeInstalledAppVersion, err := impl.installedAppRepository.GetActiveInstalledAppVersionByInstalledAppId(installedApp.InstalledAppId)
if err != nil {
impl.Logger.Errorw("error", "err", err)
return installedApp, false, nil
return installedApp, false, err
}

//validate relations
if versionHistory.InstalledAppVersionId != installedApp.Id || installedApp.InstalledAppId != installedAppVersion.InstalledAppId {
impl.Logger.Errorw("error", "err", err)
return installedApp, false, fmt.Errorf("bad request, ids are not inter-linked")
err = &util.ApiError{Code: "400", HttpStatusCode: 400, UserMessage: "bad request, requested version are not belongs to each other", InternalMessage: ""}
return installedApp, false, err
}

installedApp.InstalledAppVersionId = installedAppVersion.Id
Expand Down