Fix annotation on docker secret create --template-driver #1785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sune Keller <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1785 +/- ##
=======================================
Coverage 56.26% 56.26%
=======================================
Files 308 308
Lines 21293 21293
=======================================
Hits 11980 11980
Misses 8439 8439
Partials 874 874 |
Member
|
introduced in #896 (part of 18.03) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full disclosure: This issue is a copy-cat act inspired by #1769.
- What I did
Fixed an annotation that was set on an incorrect flag
- How I did it
Spotted it while working on deferred client initialization
cc @thaJeztah