Added option to disable log prefix via cli #7435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there any updates on this PR? I would also like to use it for my system. |
Author
|
Updated PR with respect to master |
|
I meant more like are there any updates on getting a reviewer to look at / merge the code? |
Author
|
@aiordache any updates? |
aiordache
reviewed
Oct 6, 2020
aiordache
approved these changes
Oct 6, 2020
Contributor
aiordache
left a comment
aiordache
left a comment
There was a problem hiding this comment.
Apart from my previous comment, SGTM! @ulyssessouza ?
rohitkg98
force-pushed
the
7416-add-disable-log-prefix-flag
branch
from
5369cf0 to
ebd3b6b
Compare
Author
|
Any updates on this @ulyssessouza ? |
ulyssessouza
suggested changes
Oct 15, 2020
Contributor
ulyssessouza
left a comment
ulyssessouza
left a comment
There was a problem hiding this comment.
In general flags disabling something use no instead of disable.
This is the case of --no-color, --no-deps, --no-build, etc...
You can run docker-compose up --help to see some examples.
rohitkg98
force-pushed
the
7416-add-disable-log-prefix-flag
branch
from
e80cbc9 to
c301c48
Compare
ulyssessouza
approved these changes
Oct 17, 2020
Signed-off-by: Kaushal Rohit <[email protected]>
rohitkg98
force-pushed
the
7416-add-disable-log-prefix-flag
branch
from
c301c48 to
cddaa77
Compare
Author
|
done, thanks! |
Author
albers
added a commit
to albers/docker-compose
that referenced
this pull request
Jan 24, 2021
This adds bash completion for docker#7435 Signed-off-by: Harald Albers <[email protected]>
This was referenced Jan 24, 2021
Add bash completion for
docker-compose logs|up --no-log-prefix, fix formatting of help message
#8067
Merged
aiordache
pushed a commit
that referenced
this pull request
Jan 26, 2021
This adds bash completion for #7435 Signed-off-by: Harald Albers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kaushal Rohit [email protected]
Resolves #7416
Added a
--no-log-prefixflag to the CLI. Added additional argument to LogPresenter calledkeep_prefix.