Skip to content

Conversation

@shin-
Copy link
Contributor

@shin- shin- commented May 2, 2019

List of PRs / issues for this release

Breaking changes

  • Support for Python 3.3 and Python 3.4 has been dropped
  • APIClient.update_service, APIClient.init_swarm, and
    DockerClient.swarm.init now return a dict from the API's response body
  • In APIClient.build and DockerClient.images.build, the use_config_proxy
    parameter now defaults to True
  • init_path is no longer a valid parameter for HostConfig

Features

  • It is now possible to provide SCTP ports for port mappings
  • ContainerSpecs now support the init parameter
  • DockerClient.swarm.init and APIClient.init_swarm now support the
    data_path_addr parameter
  • APIClient.update_swarm and DockerClient.swarm.update now support the
    rotate_manager_unlock_key parameter
  • APIClient.update_service returns the API's response body as a dict
  • APIClient.init_swarm, and DockerClient.swarm.init now return the API's
    response body as a dict

Bugfixes

  • Fixed PlacementPreference instances to produce a valid API type
  • Fixed a bug where not setting a value for buildargs in build could cause
    the library to attempt accessing attributes of a None value
  • Fixed a bug where setting the volume_driver parameter in
    DockerClient.containers.create would result in an error
  • APIClient.inspect_distribution now correctly sets the authentication
    headers on the request, allowing it to be used with private repositories
    This change also applies to DockerClient.get_registry_data

chris-crone and others added 30 commits January 10, 2019 18:20
Signed-off-by: Christopher Crone <[email protected]>
Update docstring for auth_config parameter in pull, push, and
inspect_distribution

Signed-off-by: Joffrey F <[email protected]>
…ls.containers to the docstring for client.containers.run()

Signed-off-by: wvaske <[email protected]>
…_container_run_documentation

Added missing options from RUN_HOST_CONFIG_KWARGS list in docker.models.containers to the docstring for client.containers.run()
Make PlacementPreference build correct context
1.30 -> 1.35

Signed-off-by: Tsuyoshi Hombashi <[email protected]>
Fix descriptions of the default API version in docs
Fix `network_mode` API documentation wording
This is because default the number of connections
in OpenSSH is 10

Signed-off-by: Ulysses Souza <[email protected]>
- Adds a BaseHTTPAdapter with a close method to ensure that the
pools is clean on close()
- Makes SSHHTTPAdapter reopen a closed connection when needed
like the others

Signed-off-by: Ulysses Souza <[email protected]>
[4.0] Terminate support for Python 3.3 (EOL in 2018)
Return API response on service update
Signed-off-by: Hannes Ljungberg <[email protected]>
Signed-off-by: Hannes Ljungberg <[email protected]>
Update changelog and next milestone
Also corrected a documentation error: the default API version from
constants is currently 1.35, not 1.30 as was sometimes listed.

Signed-off-by: Barry Shapira <[email protected]>

Removed accidental whitespace.

Signed-off-by: Barry Shapira <[email protected]>
The integration tests require restarting the swarm once for each
test.  I had done so manually with self.init_swarm(force_new_cluster=True)
but that wasn't resetting the swarm state correctly.  The usual
test teardown procedure cleans up correctly.

Signed-off-by: Barry Shapira <[email protected]>
Following #2201 (review)

Signed-off-by: Hannes Ljungberg <[email protected]>
Co-authored-by: Hannes Ljungberg <[email protected]>
Co-authored-by: bluikko <[email protected]>
@shin- shin- added this to the 4.0.0 milestone May 2, 2019
shin- and others added 3 commits May 2, 2019 12:46
Change use_config_proxy default value to True to match CLI behavior
@docker docker deleted a comment from GordonTheTurtle May 14, 2019
Ulysses Souza and others added 4 commits May 13, 2019 22:44
This test is quite flaky on ssl integration test

Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Ulysses Souza <[email protected]>
Signed-off-by: Joffrey F <[email protected]>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "4.0.0-release" [email protected]:docker/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354566592
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@shin- shin- changed the title [WIP] 4.0.0 release 4.0.0 release May 14, 2019
@shin-
Copy link
Contributor Author

shin- commented May 14, 2019

@ulyssessouza Do you want to give this one final glance before I push it out the door? 🐱

@ulyssessouza
Copy link
Contributor

@shin- Sure!
I'll run some tests on docker-compose and give you feedback!

@ulyssessouza
Copy link
Contributor

For me, the only thing missing is #2339. Otherwise LGTM

Signed-off-by: Ulysses Souza <[email protected]>
@shin- shin- merged commit 5d42ab8 into release May 19, 2019
shin- added a commit that referenced this pull request May 19, 2019
4.0.0 release

Signed-off-by: Joffrey F <[email protected]>
@shin- shin- deleted the 4.0.0-release branch May 19, 2019 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.