Fixes, Enhancements, and Upgrades (Oh My!) #106
Conversation
0 - Full path with digest 1 - full path to image, without digest 2 - server 3 - library 4 - image name 5 - tag 6 - digest
src/data-provider.js
Outdated
| let imageNameMatches = imageNameRegex.exec(cloned.Spec.ContainerSpec.Image); | ||
| let tagName = imageNameMatches[3]; | ||
| let dateStamp = dt.getDate() + "/" + (dt.getMonth() + 1) + " " + dt.getHours() + ":" + dt.getMinutes(); | ||
| let dateStamp = (1900+dt.getYear()) + "-" + ('0' + (dt.getMonth() + 1)).slice(-2) + "-" + ('0' + dt.getDate()).slice(-2) + " " + ('0' + dt.getHours()).slice(-2) + ":" + ('0' + dt.getMinutes()).slice(-2); |
There was a problem hiding this comment.
How about dt.getFullYear().toString().substr(2,2) for the year so it fits better to to the square (no need for the 2 first numbers for a long time)
There was a problem hiding this comment.
I shrunk the zoom to make a cleaner tighter picture.
When it's full, there's plenty of space. BUT, yes, I will do dt.getFullYear() because I derped.
There was a problem hiding this comment.
you could also add that image to the readme, the one in it needs an update 😄
There was a problem hiding this comment.
@pahakalle I will add one final commit updating the README.md with a new image once we finalize all the visual bits and changes.
Do we want anything else for this PR, or shall I do that now?
Fix for the following tags: * no tag * no hash
Make use of Docker caching. That's what it's there for.
|
Ok, all done with the pushes. Any more changes requested? |
|
Any ETA on having these improvements merged? |
|
We're trying to keep this sample app as simple as possible. With all the enhancements, this would become a greater maintenance burden. If you have fixes to broken features, please submit them separately. |
4 participants
drainhas a gray background (third server),pausehas a gray border (fourth server),activehas a green border.1/4 4:3to2018-04-01 04:03node-metabox. Removes RAM/CPU type.adding...
data-providerto usegetFullYear()as suggested. #derp