Skip to content

Fixes, Enhancements, and Upgrades (Oh My!) #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jnovack wants to merge 15 commits into from
Closed

Fixes, Enhancements, and Upgrades (Oh My!) #106

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
67208a0
Highlight 'Drain' Nodes (fixes #75 and #58)
jnovack Apr 1, 2018
3643a57
Fix dateStamp to be ISO 8601 complaint, with zero-padding
jnovack Apr 1, 2018
0f4b889
Update regex for images. Completely parses full path.
jnovack Apr 1, 2018
d6a44a8
Add role to node-meta box
jnovack Apr 1, 2018
3c7daf8
hide the filter by default to save space on "dashboard" displays
jnovack Apr 1, 2018
f9417a7
style upgrades
jnovack Apr 1, 2018
14048cd
regex fix for official docker images under the "_" library
jnovack Apr 1, 2018
241ad1a
this commit does not exist... nobody sees this.
jnovack Apr 2, 2018
b78d5c9
Shrink node name to fit at least 20 characters.
jnovack Apr 2, 2018
1f6204a
Sometimes I REALLLLLLY hate regex.
jnovack Apr 7, 2018
124f690
whitespaces fixes in my travels
jnovack Apr 7, 2018
c3e7f51
corrected floating green icon
jnovack Apr 7, 2018
00e58e1
Now NPM Friendly!!
jnovack Apr 7, 2018
91bb18c
Status.Addr occasionally shows 0.0.0.0, removing.
jnovack Apr 7, 2018
5383bdb
Updated Image
jnovack Apr 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data-provider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ let physicalStructProvider = ([initialNodes, initialContainers]) => {
let imageNameRegex = /([^/]+?)(\:([^/]+))?$/;
let imageNameMatches = imageNameRegex.exec(cloned.Spec.ContainerSpec.Image);
let tagName = imageNameMatches[3];
let dateStamp = dt.getDate() + "/" + (dt.getMonth() + 1) + " " + dt.getHours() + ":" + dt.getMinutes();
let dateStamp = (1900+dt.getYear()) + "-" + ('0' + (dt.getMonth() + 1)).slice(-2) + "-" + ('0' + dt.getDate()).slice(-2) + " " + ('0' + dt.getHours()).slice(-2) + ":" + ('0' + dt.getMinutes()).slice(-2);
Copy link
Contributor

@ThatLurker ThatLurker Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about dt.getFullYear().toString().substr(2,2) for the year so it fits better to to the square (no need for the 2 first numbers for a long time)

Copy link
Author

@jnovack jnovack Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I shrunk the zoom to make a cleaner tighter picture.

When it's full, there's plenty of space. BUT, yes, I will do dt.getFullYear() because I derped.

image

Copy link
Contributor

@ThatLurker ThatLurker Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@ThatLurker ThatLurker Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also add that image to the readme, the one in it needs an update 😄

Copy link
Author

@jnovack jnovack Apr 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pahakalle I will add one final commit updating the README.md with a new image once we finalize all the visual bits and changes.

Do we want anything else for this PR, or shall I do that now?

let startState = cloned.Status.State;


Expand Down