Skip to content

Respect precision when casting to datetime #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelamayxie merged 4 commits into from
Oct 22, 2025
Merged

Respect precision when casting to datetime #3278

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4244a2a
Respect precision when casting to datetime
angelamayxie Oct 22, 2025
c5d4cc2
use max datetime precision for comparisons
angelamayxie Oct 22, 2025
8a1d37e
explicitly cast to max precision for comparisons
angelamayxie Oct 22, 2025
62efe69
add datetime comparison test
angelamayxie Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add datetime comparison test
  • Loading branch information
@angelamayxie
angelamayxie committed Oct 22, 2025
commit 62efe690ace1363639adc27cfc5858d64413a489
4 changes: 4 additions & 0 deletions enginetest/queries/queries.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4281,6 +4281,10 @@ SELECT * FROM cte WHERE d = 2;`,
ExpectedWarningsCount: 1,
Expected: []sql.Row{{time.Date(2020, time.January, 1, 12, 34, 56, 123456000, time.UTC)}},
},
{
Query: "select cast('2020-01-01 12:34:56.123456' as datetime(6)) > cast('2020-01-01 12:34:56' as datetime)",
Expected: []sql.Row{{true}},
},
{
Query: `SELECT * FROM (SELECT * FROM (SELECT * FROM (SELECT * FROM othertable) othertable_one) othertable_two) othertable_three WHERE s2 = 'first'`,
Expected: []sql.Row{
Expand Down
2 changes: 0 additions & 2 deletions sql/types/datetime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,6 @@ var (
Date = MustCreateDatetimeType(sqltypes.Date, 0)
// Datetime is a date and a time with default precision (no fractional seconds).
Datetime = MustCreateDatetimeType(sqltypes.Datetime, 0)
// DatetimeDefaultPrecision is a date and a time without a specified precision
DatetimeDefaultPrecision = MustCreateDatetimeType(sqltypes.Datetime, 0)
// DatetimeMaxPrecision is a date and a time with maximum precision
DatetimeMaxPrecision = MustCreateDatetimeType(sqltypes.Datetime, MaxDatetimePrecision)
// Timestamp is a UNIX timestamp with default precision (no fractional seconds).
Expand Down