Skip to content

Respect precision when casting to datetime #3278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelamayxie merged 4 commits into from
Oct 22, 2025
+18 −23
Merged

Respect precision when casting to datetime #3278

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4244a2a
Respect precision when casting to datetime
angelamayxie Oct 22, 2025
c5d4cc2
use max datetime precision for comparisons
angelamayxie Oct 22, 2025
8a1d37e
explicitly cast to max precision for comparisons
angelamayxie Oct 22, 2025
62efe69
add datetime comparison test
angelamayxie Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use max datetime precision for comparisons
  • Loading branch information
@angelamayxie
angelamayxie committed Oct 22, 2025
commit c5d4cc2c19a764d36b9069c235da5d81e2925ad3
10 changes: 6 additions & 4 deletions sql/expression/comparison.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,15 @@ func (c *comparison) castLeftAndRight(ctx *sql.Context, left, right interface{})
}

if types.IsTime(leftType) || types.IsTime(rightType) {
// TODO: We need to set to actual Datetime type
l, r, err := convertLeftAndRight(ctx, left, right, ConvertToDatetime)
l, _, err := types.DatetimeMaxPrecision.Convert(ctx, left)
if err != nil {
return nil, nil, nil, err
}

return l, r, types.DatetimeDefaultPrecision, nil
r, _, err := types.DatetimeMaxPrecision.Convert(ctx, right)
if err != nil {
return nil, nil, nil, err
}
return l, r, types.DatetimeMaxPrecision, nil
}

// Rely on types.JSON.Compare to handle JSON comparisons
Expand Down
Loading