-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Use NuGet Trusted Publishing #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Switch to using GitHub OIDC for pushing packages to NuGet.org with Trusted Publishing. Resolves #3566.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3574 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 111 111
Lines 3858 3858
Branches 778 778
=======================================
Hits 3652 3652
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
API key has expired. Once Trusted Publishing has been configured can merge this and then release v10.0.2 again. |
|
Relevant changes have been made in NuGet, so this should work now. Will find out for sure when the next release happens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request attempts to implement NuGet Trusted Publishing using GitHub OIDC authentication to replace the traditional API key-based authentication for pushing packages to NuGet.org. However, the implementation appears to use a non-standard approach that may not work as intended.
Key Changes:
- Adds
id-token: writepermission to thepublish-nugetjob to enable OIDC token generation - Introduces a
NuGet log instep using an unverifiedNuGet/loginaction - Changes API key source from
secrets.NUGET_TOKENto the output of the login step
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Switch to using GitHub OIDC for pushing packages to NuGet.org with Trusted Publishing.