Suppress zizmor false-positive #3696
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suppress false positive for trusted publishing usage for MyGet.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| SOURCE: https://api.nuget.org/v3/index.json | ||
| run: dotnet nuget push "*.nupkg" --api-key "${API_KEY}" --skip-duplicate --source "${SOURCE}" && echo "::notice title=nuget.org::Published version ${PACKAGE_VERSION} to NuGet.org." | ||
| run: | | ||
| dotnet nuget push "*.nupkg" --api-key "${API_KEY}" --skip-duplicate --source "${SOURCE}" && echo "::notice title=nuget.org::Published version ${PACKAGE_VERSION} to NuGet.org." |
Check notice
Code scanning / zizmor
prefer trusted publishing for authentication Note
There was a problem hiding this comment.
Pull request overview
This PR suppresses a zizmor false-positive warning for the MyGet publishing job by adding an ignore comment explaining that MyGet does not support trusted publishing. The changes convert single-line run commands to multi-line format for both the MyGet and NuGet publishing jobs.
Key Changes
- Added zizmor ignore directive for the MyGet publishing step to suppress the
use-trusted-publishingwarning - Converted both MyGet and NuGet publishing steps from single-line to multi-line
runformat
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3696 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 111 111
Lines 3858 3858
Branches 778 778
=======================================
Hits 3652 3652
Misses 206 206
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Dec 12, 2025
Open
This was referenced Dec 23, 2025
github-actions bot
pushed a commit
to EelcoLos/nx-tinkering
that referenced
this pull request
Dec 23, 2025
Updated [swashbuckle.aspnetcore.cli](https://github.com/domaindrivendev/Swashbuckle.AspNetCore) from 10.0.1 to 10.1.0. <details> <summary>Release notes</summary> _Sourced from [swashbuckle.aspnetcore.cli's releases](https://github.com/domaindrivendev/Swashbuckle.AspNetCore/releases)._ ## 10.1.0 ## What's Changed ### New Features * Add public method `SchemaRepository.ReplaceSchemaId` by @bkoelman in domaindrivendev/Swashbuckle.AspNetCore#3708 ### Bug Fixes * Exclude inherited properties only when base added to `AllOf` by @John-Paul-R in domaindrivendev/Swashbuckle.AspNetCore#3692 ### Miscellaneous * Add clarifying example in migration guide to v10 by @markuspalme in domaindrivendev/Swashbuckle.AspNetCore#3672 * Add markdown linter by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3673 * Update dependencies by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3685 * Validate OpenAPI documents create valid C# clients by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3686 * End-to-end client validation tests by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3687 * Add NSwag client test by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3689 * Fix GitHub step summaries by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3691 * Clarify compatibility by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3694 * Update zizmor by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3695 * Suppress zizmor false-positive by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3696 * Refactor tests by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3705 * Use NuGet Trusted Publishing by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3574 * Annotate `TryLookupByType` with nullability hints by @martincostello in domaindrivendev/Swashbuckle.AspNetCore#3719 * Bump swagger-ui-dist to 5.31.0 by @dependabot in domaindrivendev/Swashbuckle.AspNetCore#3720 ## New Contributors * @markuspalme made their first contribution in domaindrivendev/Swashbuckle.AspNetCore#3672 * @John-Paul-R made their first contribution in domaindrivendev/Swashbuckle.AspNetCore#3692 **Full Changelog**: domaindrivendev/Swashbuckle.AspNetCore@v10.0.1...v10.1.0 Commits viewable in [compare view](domaindrivendev/Swashbuckle.AspNetCore@v10.0.1...v10.1.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suppress false positive for trusted publishing usage for MyGet.